chrome/common/extensions/features/base_feature_provider_unittest.cc - Issue 22299009: Move channel-related (Chrome-specific) global state out of Feature.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/features/base_feature_provider_unittest.cc

Issue 22299009: Move channel-related (Chrome-specific) global state out of Feature. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/api/storage/storage_schema_manifest_handler_unittest.cc ('k') | chrome/common/extensions/features/complex_feature_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/features/base_feature_provider_unittest.cc

diff --git a/chrome/common/extensions/features/base_feature_provider_unittest.cc b/chrome/common/extensions/features/base_feature_provider_unittest.cc

index d9f1b2855976df4bba1bd25367ef48f9267c9c88..30f6abb358cf2dc02defb1bb916e03dbc8152764 100644

--- a/chrome/common/extensions/features/base_feature_provider_unittest.cc

+++ b/chrome/common/extensions/features/base_feature_provider_unittest.cc

@@ -4,6 +4,7 @@

#include "chrome/common/extensions/features/base_feature_provider.h"

+#include "chrome/common/extensions/features/feature_channel.h"

#include "chrome/common/extensions/features/permission_feature.h"

#include "chrome/common/extensions/value_builder.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -164,7 +165,7 @@ TEST(BaseFeatureProviderTest, ComplexFeatures) {

// Make sure both rules are applied correctly.

{

- Feature::ScopedCurrentChannel current_channel(VersionInfo::CHANNEL_BETA);

+ ScopedCurrentChannel current_channel(VersionInfo::CHANNEL_BETA);

EXPECT_EQ(Feature::IS_AVAILABLE, feature->IsAvailableToManifest(

"1",

Manifest::TYPE_EXTENSION,

@@ -177,7 +178,7 @@ TEST(BaseFeatureProviderTest, ComplexFeatures) {

Feature::UNSPECIFIED_PLATFORM).result());

}

{

- Feature::ScopedCurrentChannel current_channel(VersionInfo::CHANNEL_STABLE);

+ ScopedCurrentChannel current_channel(VersionInfo::CHANNEL_STABLE);

EXPECT_NE(Feature::IS_AVAILABLE, feature->IsAvailableToManifest(

"1",

Manifest::TYPE_EXTENSION,