Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 22299007: [Android] Move content_browsertests to main waterfall/trybots. (Closed)

Created:
7 years, 4 months ago by frankf
Modified:
7 years, 3 months ago
Reviewers:
craigdh, cmp
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, navabi1, hinoka
Visibility:
Public.

Description

[Android] Move content_browsertests to main waterfall/trybots. It's passing consistently on android_fyi_dbg trybots and on FYI waterfall bots running ICS. BUG=270144 NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216442

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/android/pylib/gtest/gtest_config.py View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
frankf
7 years, 4 months ago (2013-08-08 17:45:13 UTC) #1
craigdh
lgtm.
7 years, 4 months ago (2013-08-08 18:24:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/frankf@chromium.org/22299007/1
7 years, 4 months ago (2013-08-08 20:29:26 UTC) #3
commit-bot: I haz the power
Change committed as 216442
7 years, 4 months ago (2013-08-08 20:32:44 UTC) #4
Isaac (use chromium)
Please get approval from the infra team for changes that increase running time of the ...
7 years, 3 months ago (2013-08-28 08:24:37 UTC) #5
frankf
1. The previous revert was due to timeouts in tests themselves not the running time. ...
7 years, 3 months ago (2013-08-28 17:30:35 UTC) #6
cmp
7 years, 3 months ago (2013-09-03 05:14:16 UTC) #7
Message was sent while issue was closed.
On 2013/08/28 17:30:35, frankf wrote:
> 1. The previous revert was due to timeouts in tests themselves not the running
> time. The original CL had infra lgtm
> 2. Adding content_browsertests has been discussed many times in the infra
> meeting. So this has been long-time coming.
> 
> Given these tests has been running for 3 weeks, I highly recommend increasing
> infra capacity instead of turning of tests.

Hey Frank, the original revert AFAIK was also because the content_browsertests
tests were taking too long to run.  Someone on Clank was supposed to look into
fixing that, but that never happened.  Android is already blocking it in most
cases, but this change causes the CQ to get very far behind.  This is a problem
for us and we can't allow any config to block the Chromium CQ so badly.

We should revert this and try to fix content_browsertests run time.  We are
separately working on increasing our capacity which involves switching our
devices from GN to N4.

Powered by Google App Engine
This is Rietveld 408576698