Issue 22298002: Don't close cookies view on search enter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22298002: Don't close cookies view on search enter. (Closed)

Created:
7 years, 4 months ago by Rune Fevang

Modified:
7 years, 4 months ago

Reviewers:
Dan Beam

CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Don't close cookies view on search enter. Hitting enter in this field should be a no-op instead of closing the overlay, as hitting enter is a natural thing to do when done typing in a search. BUG=266710 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215831

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -1 line)			Patch
	M	chrome/browser/resources/options/cookies_view.js	View		1 chunk	+7 lines, -1 line	0 comments	Download
	M	chrome/browser/ui/webui/options/cookies_view_browsertest.js	View		1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rfevang@chromium.org/22298002/1

7 years, 4 months ago (2013-08-06 00:05:12 UTC) #3

Message was sent while issue was closed.

Change committed as 215831

Expand Messages | Collapse Messages