Issue 22296002: Make the windows API depend on the tabs API not the tabs permission.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22296002: Make the windows API depend on the tabs API not the tabs permission. (Closed)

Created:
7 years, 4 months ago by not at google - send to devlin

Modified:
7 years, 4 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Make the windows API depend on the tabs API not the tabs permission. BUG=268590 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215830

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/common/extensions/api/_api_features.json	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

Matt Perry

Thanks for the fix. What does it mean for an API to depend on another ...

7 years, 4 months ago (2013-08-05 21:49:44 UTC) #2

not at google - send to devlin

Basically what you'd expect. When evaluating whether an extension has the windows API, it checks ...

7 years, 4 months ago (2013-08-05 21:55:22 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/22296002/15001

7 years, 4 months ago (2013-08-05 21:58:49 UTC) #4

Message was sent while issue was closed.

Change committed as 215830