Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issue 22294004: Suppressing alerts for end users. (Closed)

Created:
7 years, 4 months ago by vadimt
Modified:
7 years, 4 months ago
CC:
chromium-reviews, arv+watch_chromium.org, govind1
Visibility:
Public.

Description

Suppressing alerts for end users. Those who manually enable debug mode, will be able to see alerts. BUG=164227 TEST= To enable debug mode (to see alerts), run DEBUG_MODE = localStorage['debug_mode'] = true; To disable, DEBUG_MODE = localStorage['debug_mode'] = false; Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216013

Patch Set 1 #

Total comments: 2

Patch Set 2 : arv@notes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -7 lines) Patch
M chrome/browser/resources/google_now/utility.js View 1 5 chunks +17 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
vadimt
7 years, 4 months ago (2013-08-06 20:16:24 UTC) #1
vadimt
7 years, 4 months ago (2013-08-06 20:19:26 UTC) #2
skare_
lgtm
7 years, 4 months ago (2013-08-06 20:20:26 UTC) #3
rgustafson
lgtm
7 years, 4 months ago (2013-08-06 20:21:40 UTC) #4
vadimt
arv@, please provide OWNER's approval
7 years, 4 months ago (2013-08-06 20:26:33 UTC) #5
arv (Not doing code reviews)
LGTM https://codereview.chromium.org/22294004/diff/1/chrome/browser/resources/google_now/utility.js File chrome/browser/resources/google_now/utility.js (right): https://codereview.chromium.org/22294004/diff/1/chrome/browser/resources/google_now/utility.js#newcode26 chrome/browser/resources/google_now/utility.js:26: function debugPopup(message) { How about debugAlert? I don't ...
7 years, 4 months ago (2013-08-06 20:30:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vadimt@chromium.org/22294004/10001
7 years, 4 months ago (2013-08-06 20:35:05 UTC) #7
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 4 months ago (2013-08-06 20:41:20 UTC) #8
vadimt
https://codereview.chromium.org/22294004/diff/1/chrome/browser/resources/google_now/utility.js File chrome/browser/resources/google_now/utility.js (right): https://codereview.chromium.org/22294004/diff/1/chrome/browser/resources/google_now/utility.js#newcode26 chrome/browser/resources/google_now/utility.js:26: function debugPopup(message) { On 2013/08/06 20:30:41, arv wrote: > ...
7 years, 4 months ago (2013-08-06 20:41:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vadimt@chromium.org/22294004/10001
7 years, 4 months ago (2013-08-06 20:49:47 UTC) #10
commit-bot: I haz the power
7 years, 4 months ago (2013-08-06 23:05:53 UTC) #11
Message was sent while issue was closed.
Change committed as 216013

Powered by Google App Engine
This is Rietveld 408576698