Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4357)

Unified Diff: chrome/test/base/in_process_browser_test.cc

Issue 22293003: Clean up compositor initialization/destruction. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cleanupcompositor: UseRealGLBindings in NetInternalsTest Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/base/in_process_browser_test.cc
diff --git a/chrome/test/base/in_process_browser_test.cc b/chrome/test/base/in_process_browser_test.cc
index 9ac7c38d24df3219c9014edb0b58f30238ed3c84..014386cc509d1cf70126790a46ea1ce6aa7d0e4a 100644
--- a/chrome/test/base/in_process_browser_test.cc
+++ b/chrome/test/base/in_process_browser_test.cc
@@ -51,7 +51,6 @@
#include "net/dns/mock_host_resolver.h"
#include "net/test/embedded_test_server/embedded_test_server.h"
#include "net/test/spawned_test_server/spawned_test_server.h"
-#include "ui/compositor/compositor_switches.h"
#if defined(OS_MACOSX)
#include "base/mac/scoped_nsautorelease_pool.h"
@@ -61,7 +60,6 @@
#include "base/win/scoped_com_initializer.h"
#include "base/win/windows_version.h"
#include "ui/base/win/atl_module.h"
-#include "ui/compositor/compositor_setup.h"
#include "win8/test/metro_registration_helper.h"
#include "win8/test/test_registrar_constants.h"
#endif
@@ -220,9 +218,6 @@ void InProcessBrowserTest::SetUp() {
com_initializer_.reset(new base::win::ScopedCOMInitializer());
ui::win::CreateATLModuleIfNeeded();
ASSERT_TRUE(win8::MakeTestDefaultBrowserSynchronously());
-
- // Ash browser tests need the real compositor.
- ui::DisableTestCompositor();
}
#endif
@@ -378,16 +373,6 @@ CommandLine InProcessBrowserTest::GetCommandLineForRelaunch() {
switches.erase(switches::kSingleProcess);
new_command_line.AppendSwitch(content::kLaunchAsBrowser);
-#if defined(USE_AURA)
- // Copy what UITestBase::SetLaunchSwitches() does, and also what
- // ChromeTestSuite does if the process had went into the test path. Otherwise
- // tests will fail on bots.
- if (!CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kDisableTestCompositor)) {
- new_command_line.AppendSwitch(switches::kTestCompositor);
- }
-#endif
-
base::FilePath user_data_dir;
PathService::Get(chrome::DIR_USER_DATA, &user_data_dir);
new_command_line.AppendSwitchPath(switches::kUserDataDir, user_data_dir);

Powered by Google App Engine
This is Rietveld 408576698