Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 22291004: Introduce fileOperationUtil. (Closed)

Created:
7 years, 4 months ago by hidehiko
Modified:
7 years, 4 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org, hirono
Visibility:
Public.

Description

Introduce fileOperationUtil. This CL introduces fileOperationUtil namespace and move/extracts some helper methods from FileCopyManager to it. This is preparation to move copyTo helper to it, so that moving the copyTo from js-side to c++-side should be simpler task. The moving copyTo will be done in following CLs. BUG=246976 TEST=Ran browser_tests --gtest_filter="*FileSystemExtensionApiTest*:*FileManagerBrowserTest*" and tested manually. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215854

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -72 lines) Patch
M chrome/browser/resources/file_manager/js/file_copy_manager.js View 9 chunks +104 lines, -72 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hidehiko
Thank you for your review in advance, - hidehiko
7 years, 4 months ago (2013-08-06 05:23:57 UTC) #1
mtomasz
lgtm
7 years, 4 months ago (2013-08-06 05:34:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/22291004/1
7 years, 4 months ago (2013-08-06 06:27:47 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-06 08:26:43 UTC) #4
Message was sent while issue was closed.
Change committed as 215854

Powered by Google App Engine
This is Rietveld 408576698