Issue 22284006: Add support for CopyFromCompositingSurfaceToVideoFrame with software compositor

Issue 22284006: Add support for CopyFromCompositingSurfaceToVideoFrame with software compositor (Closed)

Created:
7 years, 4 months ago by jbauman

Modified:
7 years, 4 months ago

Reviewers:
danakj, piman

CC:
chromium-reviews, joi+watch-content_chromium.org, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, miu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add support for CopyFromCompositingSurfaceToVideoFrame with software compositor This allows RWHVA::CopyFromCompositingSurfaceToVideoFrame to work when the CopyOutputResult contains a bitmap, which happens with the software renderer. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215846

Patch Set 1 #

Total comments: 1

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -5 lines)			Patch
	M	content/browser/renderer_host/render_widget_host_view_aura.cc	View		3 chunks	+29 lines, -5 lines	1 comment	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/22284006/1

7 years, 4 months ago (2013-08-06 02:55:55 UTC) #3

danakj

https://codereview.chromium.org/22284006/diff/1/content/browser/renderer_host/render_widget_host_view_aura.cc File content/browser/renderer_host/render_widget_host_view_aura.cc (right): https://codereview.chromium.org/22284006/diff/1/content/browser/renderer_host/render_widget_host_view_aura.cc#newcode1387 content/browser/renderer_host/render_widget_host_view_aura.cc:1387: gfx::Rect(current_frame_size_), Why this change? We want to copy the ...

7 years, 4 months ago (2013-08-06 15:25:03 UTC) #5

jbauman

On 2013/08/06 15:25:03, danakj wrote: > https://codereview.chromium.org/22284006/diff/1/content/browser/renderer_host/render_widget_host_view_aura.cc > File content/browser/renderer_host/render_widget_host_view_aura.cc (right): > > https://codereview.chromium.org/22284006/diff/1/content/browser/renderer_host/render_widget_host_view_aura.cc#newcode1387 > ...

7 years, 4 months ago (2013-08-06 20:18:43 UTC) #6

danakj

7 years, 4 months ago (2013-08-06 20:30:24 UTC) #7

On Tue, Aug 6, 2013 at 4:18 PM, <jbauman@chromium.org> wrote:

> On 2013/08/06 15:25:03, danakj wrote:
>
> https://codereview.chromium.**org/22284006/diff/1/content/**
>
browser/renderer_host/render_**widget_host_view_aura.cc<https://codereview.chromium.org/22284006/diff/1/content/browser/renderer_host/render_widget_host_view_aura.cc>
>
>> File content/browser/renderer_host/**render_widget_host_view_aura.**cc
>> (right):
>>
>
>
> https://codereview.chromium.**org/22284006/diff/1/content/**
>
browser/renderer_host/render_**widget_host_view_aura.cc#**newcode1387<https://codereview.chromium.org/22284006/diff/1/content/browser/renderer_host/render_widget_host_view_aura.cc#newcode1387>
>
>> content/browser/renderer_host/**render_widget_host_view_aura.**cc:1387:
>> gfx::Rect(current_frame_size_)**,
>> Why this change? We want to copy the full layer's size. This variable, it
>>
> seems,
>
>> is not updated at all if you are running ubercomp?
>>
>
> current_surface_ doesn't exist when using the software compositor (or with
> ubercomp?). current_frame_size_ exists everywhere, and seems to be updated
> in
> SwapDelegatedFrame.
>

Ohh so it is! Thanks! (also didn't notice this was using current_surface_
before.. oops.)


>
https://codereview.chromium.**org/22284006/<https://codereview.chromium.org/2...
>

Expand Messages | Collapse Messages