Chromium Code Reviews
Help | Chromium Project | Sign in
(100)

Issue 22277007: chrome://inspect: Add "open", "close" and "reload" actions to Devices tab (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 months, 1 week ago by Vladislav Kaznacheev
Modified:
8 months, 1 week ago
Reviewers:
pfeldman
CC:
chromium-reviews_chromium.org, vsevik, yurys, paulirish+reviews_chromium.org, arv+watch_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Visibility:
Public.

Description

chrome://inspect: Add "open", "close" and "reload" actions to Devices tab

BUG=267431
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216225

Patch Set 1 #

Total comments: 12

Patch Set 2 : "Addressed comments" #

Total comments: 8

Patch Set 3 : Addressed comments #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+401 lines, -88 lines) Lint Patch
M chrome/browser/devtools/adb_web_socket.cc View 1 2 1 chunk +1 line, -1 line 0 comments 0 errors Download
M chrome/browser/devtools/devtools_adb_bridge.h View 1 2 4 chunks +20 lines, -8 lines 0 comments ? errors Download
M chrome/browser/devtools/devtools_adb_bridge.cc View 1 2 6 chunks +118 lines, -6 lines 0 comments ? errors Download
M chrome/browser/resources/inspect/inspect.css View 1 1 chunk +23 lines, -0 lines 0 comments ? errors Download
M chrome/browser/resources/inspect/inspect.js View 1 2 4 chunks +122 lines, -50 lines 0 comments ? errors Download
M chrome/browser/ui/webui/inspect_ui.h View 2 chunks +8 lines, -1 line 0 comments 1 errors Download
M chrome/browser/ui/webui/inspect_ui.cc View 1 2 11 chunks +109 lines, -22 lines 0 comments ? errors Download
Commit:

Messages

Total messages: 12
Vladislav Kaznacheev
8 months, 1 week ago #1
pfeldman
https://codereview.chromium.org/22277007/diff/1/chrome/browser/devtools/devtools_adb_bridge.cc File chrome/browser/devtools/devtools_adb_bridge.cc (right): https://codereview.chromium.org/22277007/diff/1/chrome/browser/devtools/devtools_adb_bridge.cc#newcode390 chrome/browser/devtools/devtools_adb_bridge.cc:390: class AdbRemotePageCommand : public base::RefCountedThreadSafe< Wat? https://codereview.chromium.org/22277007/diff/1/chrome/browser/devtools/devtools_adb_bridge.cc#newcode421 chrome/browser/devtools/devtools_adb_bridge.cc:421: class ...
8 months, 1 week ago #2
Vladislav Kaznacheev
PTAL https://chromiumcodereview.appspot.com/22277007/diff/1/chrome/browser/devtools/devtools_adb_bridge.cc File chrome/browser/devtools/devtools_adb_bridge.cc (right): https://chromiumcodereview.appspot.com/22277007/diff/1/chrome/browser/devtools/devtools_adb_bridge.cc#newcode390 chrome/browser/devtools/devtools_adb_bridge.cc:390: class AdbRemotePageCommand : public base::RefCountedThreadSafe< Replaced with a ...
8 months, 1 week ago #3
pfeldman
https://codereview.chromium.org/22277007/diff/9001/chrome/browser/devtools/adb_web_socket.cc File chrome/browser/devtools/adb_web_socket.cc (right): https://codereview.chromium.org/22277007/diff/9001/chrome/browser/devtools/adb_web_socket.cc#newcode66 chrome/browser/devtools/adb_web_socket.cc:66: device_->HttpConnect( HttpUpgrade https://codereview.chromium.org/22277007/diff/9001/chrome/browser/devtools/devtools_adb_bridge.cc File chrome/browser/devtools/devtools_adb_bridge.cc (right): https://codereview.chromium.org/22277007/diff/9001/chrome/browser/devtools/devtools_adb_bridge.cc#newcode669 chrome/browser/devtools/devtools_adb_bridge.cc:669: SendProtocolCommand("Page.reload", ...
8 months, 1 week ago #4
Vladislav Kaznacheev
https://chromiumcodereview.appspot.com/22277007/diff/9001/chrome/browser/devtools/adb_web_socket.cc File chrome/browser/devtools/adb_web_socket.cc (right): https://chromiumcodereview.appspot.com/22277007/diff/9001/chrome/browser/devtools/adb_web_socket.cc#newcode66 chrome/browser/devtools/adb_web_socket.cc:66: device_->HttpConnect( On 2013/08/07 09:48:12, pfeldman wrote: > HttpUpgrade Done. ...
8 months, 1 week ago #5
pfeldman
lgtm
8 months, 1 week ago #6
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/22277007/19001
8 months, 1 week ago #7
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/22277007/19001
8 months, 1 week ago #8
I haz the power (commit-bot)
Failed to apply patch for chrome/browser/devtools/adb_web_socket.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
8 months, 1 week ago #9
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/22277007/19001
8 months, 1 week ago #10
I haz the power (commit-bot)
Failed to apply patch for chrome/browser/devtools/adb_web_socket.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
8 months, 1 week ago #11
Vladislav Kaznacheev
8 months, 1 week ago #12
This has been committed by the CQ but not marked as such.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1275:d14800f88434