chrome://inspect: Add "open", "close" and "reload" actions to Devices tab

chrome://inspect: Add "open", "close" and "reload" actions to Devices tab

BUG=267431
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216225

[pfeldman, 2013-08-06 13:33:34]

https://codereview.chromium.org/22277007/diff/1/chrome/browser/devtools/devto...
File chrome/browser/devtools/devtools_adb_bridge.cc (right):

https://codereview.chromium.org/22277007/diff/1/chrome/browser/devtools/devto...
chrome/browser/devtools/devtools_adb_bridge.cc:390: class AdbRemotePageCommand :
public base::RefCountedThreadSafe<
Wat?

https://codereview.chromium.org/22277007/diff/1/chrome/browser/devtools/devto...
chrome/browser/devtools/devtools_adb_bridge.cc:421: class DebuggerCommand :
public AdbWebSocket::Delegate {
Lets split this into declaration and definition with nice comment separators
between classes.

https://codereview.chromium.org/22277007/diff/1/chrome/browser/devtools/devto...
chrome/browser/devtools/devtools_adb_bridge.cc:445: delete this;
This object leaks when message loop closes.

https://codereview.chromium.org/22277007/diff/1/chrome/browser/devtools/devto...
chrome/browser/devtools/devtools_adb_bridge.cc:710: if (it !=
g_host_delegates.Get().end())
Please don't

https://codereview.chromium.org/22277007/diff/1/chrome/browser/devtools/devto...
chrome/browser/devtools/devtools_adb_bridge.cc:735: new AdbRemotePageCommand(
JsonCommand
ProtocolCommand

https://codereview.chromium.org/22277007/diff/1/chrome/browser/devtools/devto...
chrome/browser/devtools/devtools_adb_bridge.cc:746: std::string body =
response.substr(result);
This is insane! Lets factor it out first plz. I know I am the one to blame.

[Vladislav Kaznacheev, 2013-08-07 09:35:12]

PTAL

https://chromiumcodereview.appspot.com/22277007/diff/1/chrome/browser/devtool...
File chrome/browser/devtools/devtools_adb_bridge.cc (right):

https://chromiumcodereview.appspot.com/22277007/diff/1/chrome/browser/devtool...
chrome/browser/devtools/devtools_adb_bridge.cc:390: class AdbRemotePageCommand :
public base::RefCountedThreadSafe<
Replaced with a bind
On 2013/08/06 13:33:34, pfeldman wrote:
> Wat?

https://chromiumcodereview.appspot.com/22277007/diff/1/chrome/browser/devtool...
chrome/browser/devtools/devtools_adb_bridge.cc:421: class DebuggerCommand :
public AdbWebSocket::Delegate {
On 2013/08/06 13:33:34, pfeldman wrote:
> Lets split this into declaration and definition with nice comment separators
> between classes.

Done.

https://chromiumcodereview.appspot.com/22277007/diff/1/chrome/browser/devtool...
chrome/browser/devtools/devtools_adb_bridge.cc:445: delete this;
Retaining DevToolsAdbBridge instance now to make sure the message loop lives
long enough.

On 2013/08/06 13:33:34, pfeldman wrote:
> This object leaks when message loop closes.

https://chromiumcodereview.appspot.com/22277007/diff/1/chrome/browser/devtool...
chrome/browser/devtools/devtools_adb_bridge.cc:710: if (it !=
g_host_delegates.Get().end())
Doing no longer.

https://chromiumcodereview.appspot.com/22277007/diff/1/chrome/browser/devtool...
chrome/browser/devtools/devtools_adb_bridge.cc:735: new AdbRemotePageCommand(
On 2013/08/06 13:33:34, pfeldman wrote:
> JsonCommand
> ProtocolCommand

Done.

https://chromiumcodereview.appspot.com/22277007/diff/1/chrome/browser/devtool...
chrome/browser/devtools/devtools_adb_bridge.cc:746: std::string body =
response.substr(result);
see https://chromiumcodereview.appspot.com/22429005/

On 2013/08/06 13:33:34, pfeldman wrote:
> This is insane! Lets factor it out first plz. I know I am the one to blame.

[pfeldman, 2013-08-07 09:48:12]

https://codereview.chromium.org/22277007/diff/9001/chrome/browser/devtools/ad...
File chrome/browser/devtools/adb_web_socket.cc (right):

https://codereview.chromium.org/22277007/diff/9001/chrome/browser/devtools/ad...
chrome/browser/devtools/adb_web_socket.cc:66: device_->HttpConnect(
HttpUpgrade

https://codereview.chromium.org/22277007/diff/9001/chrome/browser/devtools/de...
File chrome/browser/devtools/devtools_adb_bridge.cc (right):

https://codereview.chromium.org/22277007/diff/9001/chrome/browser/devtools/de...
chrome/browser/devtools/devtools_adb_bridge.cc:669:
SendProtocolCommand("Page.reload", NULL);
kPageReloadCommand

https://codereview.chromium.org/22277007/diff/9001/chrome/browser/devtools/de...
chrome/browser/devtools/devtools_adb_bridge.cc:722: params.SetString("url",
url);
kUrl

https://codereview.chromium.org/22277007/diff/9001/chrome/browser/devtools/de...
File chrome/browser/devtools/devtools_adb_bridge.h (right):

https://codereview.chromium.org/22277007/diff/9001/chrome/browser/devtools/de...
chrome/browser/devtools/devtools_adb_bridge.h:138: std::string global_id() {
return global_id_; }
It belongs to the client.

[Vladislav Kaznacheev, 2013-08-07 12:11:05]

https://chromiumcodereview.appspot.com/22277007/diff/9001/chrome/browser/devt...
File chrome/browser/devtools/adb_web_socket.cc (right):

https://chromiumcodereview.appspot.com/22277007/diff/9001/chrome/browser/devt...
chrome/browser/devtools/adb_web_socket.cc:66: device_->HttpConnect(
On 2013/08/07 09:48:12, pfeldman wrote:
> HttpUpgrade

Done.

https://chromiumcodereview.appspot.com/22277007/diff/9001/chrome/browser/devt...
File chrome/browser/devtools/devtools_adb_bridge.cc (right):

https://chromiumcodereview.appspot.com/22277007/diff/9001/chrome/browser/devt...
chrome/browser/devtools/devtools_adb_bridge.cc:669:
SendProtocolCommand("Page.reload", NULL);
On 2013/08/07 09:48:12, pfeldman wrote:
> kPageReloadCommand

Done. Also kPageNavigateCommand

https://chromiumcodereview.appspot.com/22277007/diff/9001/chrome/browser/devt...
chrome/browser/devtools/devtools_adb_bridge.cc:722: params.SetString("url",
url);
On 2013/08/07 09:48:12, pfeldman wrote:
> kUrl

Done.

https://chromiumcodereview.appspot.com/22277007/diff/9001/chrome/browser/devt...
File chrome/browser/devtools/devtools_adb_bridge.h (right):

https://chromiumcodereview.appspot.com/22277007/diff/9001/chrome/browser/devt...
chrome/browser/devtools/devtools_adb_bridge.h:138: std::string global_id() {
return global_id_; }
On 2013/08/07 09:48:12, pfeldman wrote:
> It belongs to the client.

Done.

[pfeldman, 2013-08-07 12:15:56]

lgtm

[commit-bot: I haz the power, 2013-08-07 14:39:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/22277007/19001

[commit-bot: I haz the power, 2013-08-07 17:42:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/22277007/19001

[commit-bot: I haz the power, 2013-08-07 17:42:13]

Failed to apply patch for chrome/browser/devtools/adb_web_socket.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/devtools/adb_web_socket.cc
  Hunk #1 FAILED at 63.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/devtools/adb_web_socket.cc.rej

Patch:       chrome/browser/devtools/adb_web_socket.cc
Index: chrome/browser/devtools/adb_web_socket.cc
diff --git a/chrome/browser/devtools/adb_web_socket.cc
b/chrome/browser/devtools/adb_web_socket.cc
index
4e207a690bca22be1e65ac1dc04b0457e13cd217..b740497923e19dc3b715ae2d288d5b3bbe6ed9bf
100644
--- a/chrome/browser/devtools/adb_web_socket.cc
+++ b/chrome/browser/devtools/adb_web_socket.cc
@@ -63,7 +63,7 @@ void AdbWebSocket::SendFrameOnHandlerThread(const std::string&
message) {
 AdbWebSocket::~AdbWebSocket() {}
 
 void AdbWebSocket::ConnectOnHandlerThread() {
-  device_->HttpQuery(
+  device_->HttpUpgrade(
       socket_name_,
       base::StringPrintf(kWebSocketUpgradeRequest, url_.c_str()),
       base::Bind(&AdbWebSocket::ConnectedOnHandlerThread, this));

[commit-bot: I haz the power, 2013-08-07 20:13:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/22277007/19001

[commit-bot: I haz the power, 2013-08-07 20:13:23]

Failed to apply patch for chrome/browser/devtools/adb_web_socket.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/devtools/adb_web_socket.cc
  Hunk #1 FAILED at 63.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/devtools/adb_web_socket.cc.rej

Patch:       chrome/browser/devtools/adb_web_socket.cc
Index: chrome/browser/devtools/adb_web_socket.cc
diff --git a/chrome/browser/devtools/adb_web_socket.cc
b/chrome/browser/devtools/adb_web_socket.cc
index
4e207a690bca22be1e65ac1dc04b0457e13cd217..b740497923e19dc3b715ae2d288d5b3bbe6ed9bf
100644
--- a/chrome/browser/devtools/adb_web_socket.cc
+++ b/chrome/browser/devtools/adb_web_socket.cc
@@ -63,7 +63,7 @@ void AdbWebSocket::SendFrameOnHandlerThread(const std::string&
message) {
 AdbWebSocket::~AdbWebSocket() {}
 
 void AdbWebSocket::ConnectOnHandlerThread() {
-  device_->HttpQuery(
+  device_->HttpUpgrade(
       socket_name_,
       base::StringPrintf(kWebSocketUpgradeRequest, url_.c_str()),
       base::Bind(&AdbWebSocket::ConnectedOnHandlerThread, this));

[Vladislav Kaznacheev, 2013-08-08 13:47:17]

This has been committed by the CQ but not marked as such.