Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 22277003: Update progress bar notification UI on Windows per latest UI decision. (Closed)

Created:
7 years, 4 months ago by jianli
Modified:
7 years, 4 months ago
Reviewers:
dewittj
CC:
chromium-reviews
Visibility:
Public.

Description

Update progress bar notification UI on Windows per latest UI decision. BUG=170924 TEST=Manual test by creating progress notifications Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215827

Patch Set 1 #

Total comments: 2

Patch Set 2 : Patch to land #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -5 lines) Patch
M ui/message_center/views/notification_view.cc View 1 5 chunks +38 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jianli
7 years, 4 months ago (2013-08-05 22:08:15 UTC) #1
dewittj
doesn't seem to include updates to the constants? https://codereview.chromium.org/22277003/diff/1/ui/message_center/views/notification_view.cc File ui/message_center/views/notification_view.cc (right): https://codereview.chromium.org/22277003/diff/1/ui/message_center/views/notification_view.cc#newcode506 ui/message_center/views/notification_view.cc:506: message_center::kProgressBarTopPadding, ...
7 years, 4 months ago (2013-08-05 22:34:39 UTC) #2
jianli
The constant updates are included in my previous Mac patch. https://codereview.chromium.org/22277003/diff/1/ui/message_center/views/notification_view.cc File ui/message_center/views/notification_view.cc (right): https://codereview.chromium.org/22277003/diff/1/ui/message_center/views/notification_view.cc#newcode506 ...
7 years, 4 months ago (2013-08-05 22:42:16 UTC) #3
dewittj
lgtm
7 years, 4 months ago (2013-08-05 22:43:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jianli@chromium.org/22277003/1
7 years, 4 months ago (2013-08-05 22:55:39 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 4 months ago (2013-08-05 23:28:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jianli@chromium.org/22277003/18003
7 years, 4 months ago (2013-08-05 23:49:28 UTC) #7
commit-bot: I haz the power
7 years, 4 months ago (2013-08-06 06:31:32 UTC) #8
Message was sent while issue was closed.
Change committed as 215827

Powered by Google App Engine
This is Rietveld 408576698