Adding the "Authenticate" step to the "MANUAL_Auth" test case. Also added the username and password…

Adding the "Authenticate" step to the "MANUAL_Auth" test case. Also added the username and password command line options.

BUG=134210
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217089

[garykac, 2013-08-07 17:52:18]

https://chromiumcodereview.appspot.com/22274016/diff/1/remoting/test/remote_d...
File remoting/test/remote_desktop_browsertest.cc (right):

https://chromiumcodereview.appspot.com/22274016/diff/1/remoting/test/remote_d...
remoting/test/remote_desktop_browsertest.cc:319: &result));
Have you tried extracting this pattern:

ASSERT_TRUE(content::ExecuteScriptAndExtractBool(
    browser()->tab_strip_model()->GetActiveWebContents(),
    "window.domAutomationController.send("
        "document.getElementById(\"Passwd\") != null);",
    &result));

so you could write simply:

ASSERT_TRUE(VerifyElement("Passwd"));

?

[garykac, 2013-08-09 17:29:05]

lgtm

https://codereview.chromium.org/22274016/diff/6001/remoting/test/remote_deskt...
File remoting/test/remote_desktop_browsertest.cc (right):

https://codereview.chromium.org/22274016/diff/6001/remoting/test/remote_deskt...
remoting/test/remote_desktop_browsertest.cc:335: // Is there a better way to
verify we are on the "Request for Permission"
This sounds like it should have a TODO at the start of the comment.

[commit-bot: I haz the power, 2013-08-09 18:12:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/weitaosu@chromium.org/22274016/13001

[commit-bot: I haz the power, 2013-08-09 19:11:51]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-08-09 20:42:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/weitaosu@chromium.org/22274016/37001

[commit-bot: I haz the power, 2013-08-09 23:18:44]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_x64_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_re...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-08-12 19:04:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/weitaosu@chromium.org/22274016/57001

[commit-bot: I haz the power, 2013-08-12 22:01:27]

Change committed as 217089