tools/telemetry/telemetry/page/page_runner.py - Issue 22268006: [Telemetry] Ensure run_benchmark sets the default values from AddCommandLineOptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_runner.py

Issue 22268006: [Telemetry] Ensure run_benchmark sets the default values from AddCommandLineOptions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Replace assertIsNone Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/page/page_runner.py

diff --git a/tools/telemetry/telemetry/page/page_runner.py b/tools/telemetry/telemetry/page/page_runner.py

index af548ffa217c82b907b78f6d77ffa23fa70b9db1..1df51dec457283f4f00680c9383ec7e09c2e86ee 100644

--- a/tools/telemetry/telemetry/page/page_runner.py

+++ b/tools/telemetry/telemetry/page/page_runner.py

@@ -263,7 +263,7 @@ def Run(test, page_set, expectations, options):

try:

test.WillRunTest(state.tab)

repeat_state = page_runner_repeat.PageRunnerRepeatState(

- options.repeat_options)

+ options.repeat_options)

repeat_state.WillRunPageSet()

while repeat_state.ShouldRepeatPageSet():

« no previous file with comments | « tools/telemetry/telemetry/core/browser_options_unittest.py ('k') | tools/telemetry/telemetry/test.py » ('j') | no next file with comments »