tools/telemetry/telemetry/core/browser_options.py - Issue 22268006: [Telemetry] Ensure run_benchmark sets the default values from AddCommandLineOptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/browser_options.py

Issue 22268006: [Telemetry] Ensure run_benchmark sets the default values from AddCommandLineOptions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Replace assertIsNone Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/browser_options.py

diff --git a/tools/telemetry/telemetry/core/browser_options.py b/tools/telemetry/telemetry/core/browser_options.py

index a77cf7598514008bc23282b671d900f5d865415a..69f304823a1bf55bf7d98c1ff7cc33d912a8be88 100644

--- a/tools/telemetry/telemetry/core/browser_options.py

+++ b/tools/telemetry/telemetry/core/browser_options.py

@@ -235,3 +235,7 @@ class BrowserOptions(optparse.Values):

def AppendExtraBrowserArg(self, arg):

if arg not in self.extra_browser_args:

self.extra_browser_args.append(arg)

+ def MergeDefaultValues(self, defaults):

+ for k, v in defaults.__dict__.items():

+ self.ensure_value(k, v)

« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/browser_options_unittest.py » ('j') | no next file with comments »