Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 22267008: Use |GetDictinonary| instead of |DictionaryPrefUpdate| in |ManageProfileHandler::RequestExistingMan… (Closed)

Created:
7 years, 4 months ago by ibra
Modified:
7 years, 4 months ago
Reviewers:
Bernhard Bauer, Sergiu
CC:
chromium-reviews, dbeam+watch-options_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Use |GetDictinonary| instead of |DictionaryPrefUpdate| in |ManageProfileHandler::RequestExistingManagedUsers| Update |ManageProfileHandler::RequestExistingManagedUsers| to use |GetDictionary()| instead of |DictionaryPrefUpdate| since it only reads the |prefs::kManagedUsers|. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215954

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/ui/webui/options/manage_profile_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ibra
Bernhard, can you please take a look? Thanks!
7 years, 4 months ago (2013-08-06 17:05:19 UTC) #1
Bernhard Bauer
lgtm
7 years, 4 months ago (2013-08-06 17:09:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ibraaaa@chromium.org/22267008/1
7 years, 4 months ago (2013-08-06 17:32:25 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-06 19:54:12 UTC) #4
Message was sent while issue was closed. 
Change committed as 215954

Powered by Google App Engine
This is Rietveld 408576698