Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2561)

Unified Diff: chrome/browser/ui/android/infobars/infobar_android.cc

Issue 2226633002: Add a feature to display a persistence toggle for permission prompts on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix null error Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/infobars/infobar_android.cc
diff --git a/chrome/browser/ui/android/infobars/infobar_android.cc b/chrome/browser/ui/android/infobars/infobar_android.cc
index ddf6d3c71a5d195bcf661bf0d160553bc1841240..c7ed723b6e19a0e5535522b7b09a37db1ac8710f 100644
--- a/chrome/browser/ui/android/infobars/infobar_android.cc
+++ b/chrome/browser/ui/android/infobars/infobar_android.cc
@@ -8,10 +8,8 @@
#include "base/android/jni_android.h"
#include "base/android/jni_string.h"
-#include "base/strings/string_util.h"
#include "chrome/browser/android/resource_mapper.h"
-#include "chrome/browser/infobars/infobar_service.h"
-#include "components/infobars/core/infobar.h"
+#include "chrome/browser/permissions/permission_infobar_delegate.h"
#include "components/infobars/core/infobar_delegate.h"
#include "jni/InfoBar_jni.h"
@@ -57,7 +55,13 @@ bool InfoBarAndroid::HasSetJavaInfoBar() const {
void InfoBarAndroid::OnButtonClicked(JNIEnv* env,
const JavaParamRef<jobject>& obj,
- jint action) {
+ jint action,
+ jboolean persist) {
+ PermissionInfobarDelegate* permission_delegate =
+ delegate()->AsPermissionInfobarDelegate();
+ if (permission_delegate && permission_delegate->ShouldShowPersistenceToggle())
+ permission_delegate->SetPersist(persist);
+
ProcessButton(action);
}

Powered by Google App Engine
This is Rietveld 408576698