tools/metrics/histograms/histograms.xml - Issue 2226633002: Add a feature to display a persistence toggle for permission prompts on Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2226633002: Add a feature to display a persistence toggle for permission prompts on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reviewer comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 4334e5024c216fc7f160995653d50b7d2b43adcb..edf97f866fd309f45e2b934b0919186c4528de5c 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -39597,6 +39597,15 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="Permissions.Prompt.Accepted.Persisted" enum="BooleanEnabled">

+ <owner>dominickn@chromium.org</owner>

+ <summary>

+ For each granted permission prompt displayed with a persistence toggle

+ (remember my decision), records whether the persistence toggle was enabled

+ (persist) or not enabled (don't persist).

+ </summary>

+</histogram>

<owner>benwells@chromium.org</owner>

<owner>tsergeant@chromium.org</owner>

@@ -39606,6 +39615,15 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="Permissions.Prompt.Denied.Persisted" enum="BooleanEnabled">

+ <owner>dominickn@chromium.org</owner>

+ <summary>

+ For each denied permission prompt displayed with a persistence toggle

+ (remember my decision), records whether the persistence toggle was enabled

+ (persist) or not enabled (don't persist).

+ </summary>

+</histogram>

<owner>dominickn@chromium.org</owner>

@@ -100905,6 +100923,8 @@ To add a new entry, add it with any value and run test to compute valid value.

<affected-histogram name="Permissions.Action"/>

<affected-histogram name="Permissions.Action.InsecureOrigin"/>

<affected-histogram name="Permissions.Action.SecureOrigin"/>

+ <affected-histogram name="Permissions.Prompt.Accepted.Persisted"/>

+ <affected-histogram name="Permissions.Prompt.Denied.Persisted"/>

<affected-histogram name="Permissions.Prompt.DismissCount"/>

<affected-histogram name="Permissions.Prompt.IgnoreCount"/>

<affected-histogram name="Permissions.Requested.CrossOrigin"/>

« chrome/android/java/src/org/chromium/chrome/browser/infobar/PermissionInfoBar.java ('K') | « chrome/common/chrome_features.cc ('k') | no next file » | no next file with comments »