Add new GM to targeted at rect->clear optimization with different xfermodes.

Add new GM to targeted at rect->clear optimization with different xfermodes.

Committed: http://code.google.com/p/skia/source/detail?r=10645

[robertphillips, 2013-08-07 23:16:14]

lgtm + ignoreable nits

https://codereview.chromium.org/22264010/diff/3001/gm/xfermodes3.cpp
File gm/xfermodes3.cpp (right):

https://codereview.chromium.org/22264010/diff/3001/gm/xfermodes3.cpp#newcode64
gm/xfermodes3.cpp:64: int x = 0, y = 0;
++m

https://codereview.chromium.org/22264010/diff/3001/gm/xfermodes3.cpp#newcode135
gm/xfermodes3.cpp:135: int x, int y, int w, int h,
const SkPaint& ?

https://codereview.chromium.org/22264010/diff/3001/gm/xfermodes3.cpp#newcode207
gm/xfermodes3.cpp:207: SkShader::kRepeat_TileMode))->unref();
Move creation & alloc of bmp to right before use in bmpCanvas?

https://codereview.chromium.org/22264010/diff/3001/gm/xfermodes3.cpp#newcode213
gm/xfermodes3.cpp:213: 
Is there a better name then fBmpShader? fGradShader?

https://codereview.chromium.org/22264010/diff/3001/gm/xfermodes3.cpp#newcode224
gm/xfermodes3.cpp:224: 
fBGShader?

https://codereview.chromium.org/22264010/diff/3001/gm/xfermodes3.cpp#newcode232
gm/xfermodes3.cpp:232: 
DEF_GM?

[bsalomon, 2013-08-08 21:00:37]

https://codereview.chromium.org/22264010/diff/3001/gm/xfermodes3.cpp
File gm/xfermodes3.cpp (right):

https://codereview.chromium.org/22264010/diff/3001/gm/xfermodes3.cpp#newcode64
gm/xfermodes3.cpp:64: int x = 0, y = 0;
On 2013/08/07 23:16:14, robertphillips wrote:
> ++m

Done.

https://codereview.chromium.org/22264010/diff/3001/gm/xfermodes3.cpp#newcode135
gm/xfermodes3.cpp:135: int x, int y, int w, int h,
On 2013/08/07 23:16:14, robertphillips wrote:
> const SkPaint& ?

Done.

https://codereview.chromium.org/22264010/diff/3001/gm/xfermodes3.cpp#newcode207
gm/xfermodes3.cpp:207: SkShader::kRepeat_TileMode))->unref();
On 2013/08/07 23:16:14, robertphillips wrote:
> Move creation & alloc of bmp to right before use in bmpCanvas?

Done.

https://codereview.chromium.org/22264010/diff/3001/gm/xfermodes3.cpp#newcode213
gm/xfermodes3.cpp:213: 
On 2013/08/07 23:16:14, robertphillips wrote:
> Is there a better name then fBmpShader? fGradShader?

It is a bmp shader. I'm testing drawing a screen filling bitmap (with
transparency). The gradient just exists to put some content in the bitmap, it
could be anything.

https://codereview.chromium.org/22264010/diff/3001/gm/xfermodes3.cpp#newcode224
gm/xfermodes3.cpp:224: 
On 2013/08/07 23:16:14, robertphillips wrote:
> fBGShader?

Done.

[commit-bot: I haz the power, 2013-08-08 21:01:12]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/bsalomon@google.com/22264010/7001

[commit-bot: I haz the power, 2013-08-08 21:13:41]

Change committed as 10645