Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Unified Diff: chrome/browser/chromeos/login/helper.cc

Issue 22264004: Remove ConnectivityStateHelper (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove redundant IsConnected() check Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/login/helper.h ('k') | chrome/browser/chromeos/login/login_utils_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/helper.cc
diff --git a/chrome/browser/chromeos/login/helper.cc b/chrome/browser/chromeos/login/helper.cc
index ff60abef99e245ce65ff0faee50b44724b64302e..a09f0c051ac3700f13504a350b285b7774cac80d 100644
--- a/chrome/browser/chromeos/login/helper.cc
+++ b/chrome/browser/chromeos/login/helper.cc
@@ -6,7 +6,9 @@
#include "ash/shell.h"
#include "base/strings/utf_string_conversions.h"
-#include "chrome/browser/chromeos/net/connectivity_state_helper.h"
+#include "chromeos/network/network_handler.h"
+#include "chromeos/network/network_state.h"
+#include "chromeos/network/network_state_handler.h"
#include "grit/generated_resources.h"
#include "grit/theme_resources.h"
#include "third_party/cros_system_api/dbus/service_constants.h"
@@ -26,31 +28,6 @@ gfx::Rect CalculateScreenBounds(const gfx::Size& size) {
return bounds;
}
-string16 GetCurrentNetworkName() {
- ConnectivityStateHelper* csh =
- ConnectivityStateHelper::Get();
-
- if (csh->IsConnectedType(flimflam::kTypeEthernet)) {
- return l10n_util::GetStringUTF16(IDS_STATUSBAR_NETWORK_DEVICE_ETHERNET);
- } else if (csh->IsConnectedType(flimflam::kTypeWifi)) {
- return UTF8ToUTF16(csh->NetworkNameForType(flimflam::kTypeWifi));
- } else if (csh->IsConnectedType(flimflam::kTypeCellular)) {
- return UTF8ToUTF16(csh->NetworkNameForType(flimflam::kTypeCellular));
- } else if (csh->IsConnectedType(flimflam::kTypeWimax)) {
- return UTF8ToUTF16(csh->NetworkNameForType(flimflam::kTypeWimax));
- } else if (csh->IsConnectingType(flimflam::kTypeEthernet)) {
- return l10n_util::GetStringUTF16(IDS_STATUSBAR_NETWORK_DEVICE_ETHERNET);
- } else if (csh->IsConnectingType(flimflam::kTypeWifi)) {
- return UTF8ToUTF16(csh->NetworkNameForType(flimflam::kTypeWifi));
- } else if (csh->IsConnectingType(flimflam::kTypeCellular)) {
- return UTF8ToUTF16(csh->NetworkNameForType(flimflam::kTypeCellular));
- } else if (csh->IsConnectingType(flimflam::kTypeWimax)) {
- return UTF8ToUTF16(csh->NetworkNameForType(flimflam::kTypeWimax));
- } else {
- return string16();
- }
-}
-
int GetCurrentUserImageSize() {
// The biggest size that the profile picture is displayed at is currently
// 220px, used for the big preview on OOBE and Change Picture options page.
@@ -62,4 +39,45 @@ int GetCurrentUserImageSize() {
ui::GetScaleFactorScale(ui::GetMaxScaleFactor());
}
+namespace login {
+
+NetworkStateHelper::NetworkStateHelper() {}
+NetworkStateHelper::~NetworkStateHelper() {}
+
+string16 NetworkStateHelper::GetCurrentNetworkName() const {
+ NetworkStateHandler* nsh = NetworkHandler::Get()->network_state_handler();
+ const NetworkState* network = nsh->ConnectedNetworkByType(
+ NetworkStateHandler::kMatchTypeNonVirtual);
+ if (network) {
+ if (network->type() == flimflam::kTypeEthernet)
+ return l10n_util::GetStringUTF16(IDS_STATUSBAR_NETWORK_DEVICE_ETHERNET);
+ return UTF8ToUTF16(network->name());
+ }
+
+ network = nsh->ConnectingNetworkByType(
+ NetworkStateHandler::kMatchTypeNonVirtual);
+ if (network) {
+ if (network->type() == flimflam::kTypeEthernet)
+ return l10n_util::GetStringUTF16(IDS_STATUSBAR_NETWORK_DEVICE_ETHERNET);
+ return UTF8ToUTF16(network->name());
+ }
+ return string16();
+}
+
+bool NetworkStateHelper::IsConnected() const {
+ chromeos::NetworkStateHandler* nsh =
+ chromeos::NetworkHandler::Get()->network_state_handler();
+ return nsh->ConnectedNetworkByType(
+ chromeos::NetworkStateHandler::kMatchTypeDefault) != NULL;
+}
+
+bool NetworkStateHelper::IsConnecting() const {
+ chromeos::NetworkStateHandler* nsh =
+ chromeos::NetworkHandler::Get()->network_state_handler();
+ return nsh->ConnectingNetworkByType(
+ chromeos::NetworkStateHandler::kMatchTypeDefault) != NULL;
+}
+
+} // namespace login
+
} // namespace chromeos
« no previous file with comments | « chrome/browser/chromeos/login/helper.h ('k') | chrome/browser/chromeos/login/login_utils_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698