Issue 22263003: [chromedriver] Implement touch down, up, and move commands.

Issue 22263003: [chromedriver] Implement touch down, up, and move commands. (Closed)

Created:
7 years, 4 months ago by craigdh

Modified:
7 years, 4 months ago

Reviewers:
frankf

CC:
chromium-reviews, kkania, frankf

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[chromedriver] Implement touch down, up, and move commands. BUG=264471 TEST=includes new Python test Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217742

Patch Set 4 : disable touchmove test on desktop #

Patch Set 5 : coordinate parameters are now absolute #

Total comments: 10

Patch Set 6 : comments addressed #

Patch Set 7 : always use the top frame #

Patch Set 8 : rebase #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+156 lines, -9 lines)			Patch
M	chrome/test/chromedriver/client/chromedriver.py	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/test/chromedriver/client/webelement.py	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/test/chromedriver/server/http_handler.cc	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/test/chromedriver/test/run_py_tests.py	View	1 2 3 4 5 6 7	3 chunks	+31 lines, -4 lines	0 comments	Download
M	chrome/test/chromedriver/test/test_expectations	View	1 2 3 4 5 6 7	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/test/chromedriver/window_commands.h	View		1 chunk	+21 lines, -0 lines	0 comments	Download
M	chrome/test/chromedriver/window_commands.cc	View	1 2 3 4 5 6	3 chunks	+86 lines, -0 lines	0 comments	Download

Messages

Total messages: 14 (0 generated)

Expand Messages | Collapse Messages

frankf

https://codereview.chromium.org/22263003/diff/3001/chrome/test/chromedriver/run_py_tests.py File chrome/test/chromedriver/run_py_tests.py (right): https://codereview.chromium.org/22263003/diff/3001/chrome/test/chromedriver/run_py_tests.py#newcode376 chrome/test/chromedriver/run_py_tests.py:376: def testTouchDownUpElement(self): What about move? https://codereview.chromium.org/22263003/diff/3001/chrome/test/chromedriver/run_py_tests.py#newcode381 chrome/test/chromedriver/run_py_tests.py:381: ' var ...

7 years, 4 months ago (2013-08-06 01:28:21 UTC) #2

craigdh

7 years, 4 months ago (2013-08-06 22:03:10 UTC) #3

frankf

https://codereview.chromium.org/22263003/diff/24001/chrome/test/chromedriver/run_py_tests.py File chrome/test/chromedriver/run_py_tests.py (right): https://codereview.chromium.org/22263003/diff/24001/chrome/test/chromedriver/run_py_tests.py#newcode69 chrome/test/chromedriver/run_py_tests.py:69: # Desktop doesn't support touch (without --touch-events). Do we ...

7 years, 4 months ago (2013-08-14 01:09:10 UTC) #7

craigdh

7 years, 4 months ago (2013-08-14 22:01:56 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/craigdh@chromium.org/22263003/34001

7 years, 4 months ago (2013-08-14 23:46:01 UTC) #11

commit-bot: I haz the power

Failed to apply patch for chrome/test/chromedriver/run_py_tests.py: While running patch -p1 --forward --force --no-backup-if-mismatch; can't find ...

7 years, 4 months ago (2013-08-14 23:46:12 UTC) #12

Failed to apply patch for chrome/test/chromedriver/run_py_tests.py:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  can't find file to patch at input line 6
  Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |Index: chrome/test/chromedriver/run_py_tests.py
  |diff --git a/chrome/test/chromedriver/run_py_tests.py
b/chrome/test/chromedriver/run_py_tests.py
  |index
35d6c9d280a68d9c9a3e264d1dc346deee1fadcc..b641dfdb95d9c1da8563dbcfdfd30cb255104d37
100755
  |--- a/chrome/test/chromedriver/run_py_tests.py
  |+++ b/chrome/test/chromedriver/run_py_tests.py
  --------------------------
  No file to patch.  Skipping patch.
  3 out of 3 hunks ignored

Patch:       chrome/test/chromedriver/run_py_tests.py
Index: chrome/test/chromedriver/run_py_tests.py
diff --git a/chrome/test/chromedriver/run_py_tests.py
b/chrome/test/chromedriver/run_py_tests.py
index
35d6c9d280a68d9c9a3e264d1dc346deee1fadcc..b641dfdb95d9c1da8563dbcfdfd30cb255104d37
100755
--- a/chrome/test/chromedriver/run_py_tests.py
+++ b/chrome/test/chromedriver/run_py_tests.py
@@ -66,8 +66,10 @@ _DESKTOP_NEGATIVE_FILTER['HEAD'] = (
         # This test is flaky since it uses setTimeout.
         # Re-enable once crbug.com/177511 is fixed and we can remove
setTimeout.
         'ChromeDriverTest.testAlert',
-        # Desktop doesn't support TAP.
+        # Desktop doesn't support touch (without --touch-events).
         'ChromeDriverTest.testSingleTapElement',
+        'ChromeDriverTest.testTouchDownUpElement',
+        'ChromeDriverTest.testTouchMovedElement',
     ]
 )
 
@@ -353,7 +355,6 @@ class ChromeDriverTest(ChromeDriverBaseTest):
         'document.body.innerHTML = "<div>old</div>";'
         'var div = document.getElementsByTagName("div")[0];'
         'div.addEventListener("click", function() {'
-        '  var div = document.getElementsByTagName("div")[0];'
         '  div.innerHTML="new<br>";'
         '});'
         'return div;')
@@ -364,14 +365,40 @@ class ChromeDriverTest(ChromeDriverBaseTest):
     div = self._driver.ExecuteScript(
         'document.body.innerHTML = "<div>old</div>";'
         'var div = document.getElementsByTagName("div")[0];'
-        'div.addEventListener("click", function() {'
-        '  var div = document.getElementsByTagName("div")[0];'
+        'div.addEventListener("touchend", function() {'
         '  div.innerHTML="new<br>";'
         '});'
         'return div;')
     div.SingleTap()
     self.assertEquals(1, len(self._driver.FindElements('tag name', 'br')))
 
+  def testTouchDownUpElement(self):
+    div = self._driver.ExecuteScript(
+        'document.body.innerHTML = "<div>old</div>";'
+        'var div = document.getElementsByTagName("div")[0];'
+        'div.addEventListener("touchend", function() {'
+        '  div.innerHTML="new<br>";'
+        '});'
+        'return div;')
+    loc = div.GetLocation()
+    self._driver.TouchDown(loc['x'], loc['y'])
+    self._driver.TouchUp(loc['x'], loc['y'])
+    self.assertEquals(1, len(self._driver.FindElements('tag name', 'br')))
+
+  def testTouchMovedElement(self):
+    div = self._driver.ExecuteScript(
+        'document.body.innerHTML = "<div>old</div>";'
+        'var div = document.getElementsByTagName("div")[0];'
+        'div.addEventListener("touchmove", function() {'
+        '  div.innerHTML="new<br>";'
+        '});'
+        'return div;')
+    loc = div.GetLocation()
+    self._driver.TouchDown(loc['x'], loc['y'])
+    self._driver.TouchMove(loc['x'] + 1, loc['y'] + 1)
+    self._driver.TouchUp(loc['x'] + 1, loc['y'] + 1)
+    self.assertEquals(1, len(self._driver.FindElements('tag name', 'br')))
+
   def testClickElementInSubFrame(self):
     self._driver.Load(self.GetHttpUrlForFile('/chromedriver/frame_test.html'))
     frame = self._driver.FindElement('tag name', 'iframe')

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/craigdh@chromium.org/22263003/42001

7 years, 4 months ago (2013-08-14 23:51:19 UTC) #13

Message was sent while issue was closed.

Change committed as 217742

Expand Messages | Collapse Messages