Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 22262003: Fix Win64 DirectX redistributables (Closed)

Created:
7 years, 4 months ago by jschuh
Modified:
7 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Fix Win64 DirectX redistributables Adds a gyp variable to simplify WINSDK path strings, and grabs the x64 files rather than x86. BUG=268525, 267893 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215814

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M build/common.gypi View 1 1 chunk +6 lines, -0 lines 0 comments Download
M content/content_common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_gpu.gypi View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jschuh
@piman for an owners rubberstamp @scottmg and @apatrick to make sure I've got the right ...
7 years, 4 months ago (2013-08-05 23:33:28 UTC) #1
piman
lgtm
7 years, 4 months ago (2013-08-05 23:35:13 UTC) #2
scottmg
lgtm https://codereview.chromium.org/22262003/diff/1/content/content_gpu.gypi File content/content_gpu.gypi (right): https://codereview.chromium.org/22262003/diff/1/content/content_gpu.gypi#newcode53 content/content_gpu.gypi:53: 'input': 'Jun2010_D3DCompiler_43_x86.cab', we don't need to extract the ...
7 years, 4 months ago (2013-08-05 23:39:03 UTC) #3
apatrick_chromium
lgtm https://codereview.chromium.org/22262003/diff/1/content/content_gpu.gypi File content/content_gpu.gypi (right): https://codereview.chromium.org/22262003/diff/1/content/content_gpu.gypi#newcode53 content/content_gpu.gypi:53: 'input': 'Jun2010_D3DCompiler_43_x86.cab', On 2013/08/05 23:39:03, scottmg wrote: > ...
7 years, 4 months ago (2013-08-06 00:06:47 UTC) #4
jschuh
https://codereview.chromium.org/22262003/diff/1/content/content_gpu.gypi File content/content_gpu.gypi (right): https://codereview.chromium.org/22262003/diff/1/content/content_gpu.gypi#newcode53 content/content_gpu.gypi:53: 'input': 'Jun2010_D3DCompiler_43_x86.cab', On 2013/08/06 00:06:47, apatrick_chromium wrote: > On ...
7 years, 4 months ago (2013-08-06 00:26:55 UTC) #5
apatrick_chromium
lgtm
7 years, 4 months ago (2013-08-06 00:27:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/22262003/6001
7 years, 4 months ago (2013-08-06 00:42:09 UTC) #7
commit-bot: I haz the power
7 years, 4 months ago (2013-08-06 06:09:48 UTC) #8
Message was sent while issue was closed.
Change committed as 215814

Powered by Google App Engine
This is Rietveld 408576698