Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Issue 22261009: aura: Fix crash in RootWindowHostX11::GetXImage(). (Closed)

Created:
7 years, 4 months ago by Daniel Erat
Modified:
7 years, 4 months ago
Reviewers:
tfarina, sadrul
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

aura: Fix crash in RootWindowHostX11::GetXImage(). r195926 accidentally broke a NULL check against XGetImage()'s return value. BUG=270311 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216933

Patch Set 1 #

Total comments: 1

Patch Set 2 : get rid of GetXImage() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -23 lines) Patch
M ui/aura/root_window_host_x11.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M ui/aura/root_window_host_x11.cc View 1 2 chunks +9 lines, -19 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Daniel Erat
7 years, 4 months ago (2013-08-10 17:07:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/22261009/1
7 years, 4 months ago (2013-08-10 17:08:38 UTC) #2
tfarina
+sadrul, for ui/aura OWNERS. https://codereview.chromium.org/22261009/diff/1/ui/aura/root_window_host_x11.cc File ui/aura/root_window_host_x11.cc (right): https://codereview.chromium.org/22261009/diff/1/ui/aura/root_window_host_x11.cc#newcode1095 ui/aura/root_window_host_x11.cc:1095: if (!image->get()) { ok.
7 years, 4 months ago (2013-08-10 17:08:58 UTC) #3
sadrul
lgtm
7 years, 4 months ago (2013-08-10 17:12:56 UTC) #4
Daniel Erat
Thanks! Mind taking another quick look? I've deleted GetXImage() to make the code simpler; the ...
7 years, 4 months ago (2013-08-10 17:16:54 UTC) #5
sadrul
Nice. lgtm
7 years, 4 months ago (2013-08-10 17:28:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/22261009/9001
7 years, 4 months ago (2013-08-10 17:35:53 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=186225
7 years, 4 months ago (2013-08-10 20:08:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/22261009/9001
7 years, 4 months ago (2013-08-11 14:19:47 UTC) #9
commit-bot: I haz the power
7 years, 4 months ago (2013-08-12 05:22:48 UTC) #10
Message was sent while issue was closed.
Change committed as 216933

Powered by Google App Engine
This is Rietveld 408576698