Refactoring: Remove dead code in DeferredImageDecoder::createFrameAtIndex

Refactoring: Remove dead code in DeferredImageDecoder::createFrameAtIndex

DeferredImageDecoder::createFrameAtIndex is used only at
ImageSource::createFrameAtIndex, and this is indirectly called by
BitmapImage::frameAtIndex, which checks that the index is less than the
number of frames. Thus, DeferredImageDecoder::createFrameAtIndex can
assume that the given |index| is less than the number of the frames.

This CL removes the dead code to improve code health.

BUG=n/a
TEST=webkit_unit_tests

Committed: https://crrev.com/9a1a7dc0502f5d16b53ce50a2fd509b0ea5cf125
Cr-Commit-Position: refs/heads/master@{#410961}

[hajimehoshi, 2016-08-09 08:58:39]

hajimehoshi@chromium.org changed reviewers:
+ fmalita@chromium.org

[hajimehoshi, 2016-08-09 08:58:40]

PTAL

[hajimehoshi, 2016-08-09 08:58:48]

The CQ bit was checked by hajimehoshi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 08:59:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 10:12:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 10:13:00]

Dry run: This issue passed the CQ dry run.

[f(malita), 2016-08-09 14:06:14]

LGTM!

This reminds me: now that Aleksandr landed deferred ICO support, we only ever
use lazy decoding and can probably delete the fallback paths.  I'll take a look
at that.

[hajimehoshi, 2016-08-10 05:00:02]

The CQ bit was checked by hajimehoshi@chromium.org

[commit-bot: I haz the power, 2016-08-10 05:00:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 05:03:44]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-10 05:05:20]

Description was changed from

==========
Refactoring: Remove dead code in DeferredImageDecoder::createFrameAtIndex

DeferredImageDecoder::createFrameAtIndex is used only at
ImageSource::createFrameAtIndex, and this is indirectly called by
BitmapImage::frameAtIndex, which checks that the index is less than the
number of frames. Thus, DeferredImageDecoder::createFrameAtIndex can
assume that the given |index| is less than the number of the frames.

This CL removes the dead code to improve code health.

BUG=n/a
TEST=webkit_unit_tests
==========

to

==========
Refactoring: Remove dead code in DeferredImageDecoder::createFrameAtIndex

DeferredImageDecoder::createFrameAtIndex is used only at
ImageSource::createFrameAtIndex, and this is indirectly called by
BitmapImage::frameAtIndex, which checks that the index is less than the
number of frames. Thus, DeferredImageDecoder::createFrameAtIndex can
assume that the given |index| is less than the number of the frames.

This CL removes the dead code to improve code health.

BUG=n/a
TEST=webkit_unit_tests

Committed: https://crrev.com/9a1a7dc0502f5d16b53ce50a2fd509b0ea5cf125
Cr-Commit-Position: refs/heads/master@{#410961}
==========

[commit-bot: I haz the power, 2016-08-10 05:05:21]

Patchset 1 (id:??) landed as
https://crrev.com/9a1a7dc0502f5d16b53ce50a2fd509b0ea5cf125
Cr-Commit-Position: refs/heads/master@{#410961}

[hajimehoshi, 2016-08-10 07:50:38]

Thank you for reviewing.

> This reminds me: now that Aleksandr landed deferred ICO support, we only ever
use lazy decoding and can probably delete the fallback paths.  I'll take a look
at that.

Just out of curiosity: You mean that we will be able to remove
|m_actualDecoder|?

[f(malita), 2016-08-10 17:25:00]

On 2016/08/10 07:50:38, hajimehoshi wrote:
> Thank you for reviewing.
> 
> > This reminds me: now that Aleksandr landed deferred ICO support, we only
ever
> use lazy decoding and can probably delete the fallback paths.  I'll take a
look
> at that.
> 
> Just out of curiosity: You mean that we will be able to remove
> |m_actualDecoder|?

I haven't really looked that far.  I thought there are some low hanging fruits,
but between you and Aleksandr it seems that most of the old cruft is gone :)

[hajimehoshi, 2016-08-12 04:34:07]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2240073002/ by hajimehoshi@chromium.org.

The reason for reverting is: Crash reported at crbug.com/636829.