Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 22258007: [CSSMQ] Use initial values as base for relative units. (Closed)

Created:
7 years, 4 months ago by rune
Modified:
7 years, 4 months ago
CC:
blink-reviews, kenneth.christiansen, dglazkov+blink, apavlov+blink_chromium.org, eae+blinkwatch, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[CSSMQ] Use initial values as base for relative units. Don't use computed style for root element as base for relative lengths. The media queries spec says: "Relative units in media queries are based on the initial value, which means that units are never based on results of declarations." BUG=269322 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155692

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed review issue. #

Patch Set 3 : --no-find-copies upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -10 lines) Patch
A LayoutTests/fast/media/mq-relative-constraints-10.html View 1 chunk +25 lines, -0 lines 0 comments Download
A LayoutTests/fast/media/mq-relative-constraints-10-expected.html View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/MediaQueryEvaluator.cpp View 1 6 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
rune
7 years, 4 months ago (2013-08-07 10:43:44 UTC) #1
kenneth.r.christiansen
https://codereview.chromium.org/22258007/diff/1/Source/core/css/MediaQueryEvaluator.cpp File Source/core/css/MediaQueryEvaluator.cpp (right): https://codereview.chromium.org/22258007/diff/1/Source/core/css/MediaQueryEvaluator.cpp#newcode353 Source/core/css/MediaQueryEvaluator.cpp:353: result = primitiveValue->computeLength<int>(style, style, 1.0 /* multiplier */, true ...
7 years, 4 months ago (2013-08-07 10:49:28 UTC) #2
rune
https://codereview.chromium.org/22258007/diff/1/Source/core/css/MediaQueryEvaluator.cpp File Source/core/css/MediaQueryEvaluator.cpp (right): https://codereview.chromium.org/22258007/diff/1/Source/core/css/MediaQueryEvaluator.cpp#newcode353 Source/core/css/MediaQueryEvaluator.cpp:353: result = primitiveValue->computeLength<int>(style, style, 1.0 /* multiplier */, true ...
7 years, 4 months ago (2013-08-07 11:46:08 UTC) #3
apavlov
lgtm. Could you please re-upload the patch using git cl upload --no-find-copies first? Since the ...
7 years, 4 months ago (2013-08-07 12:46:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/22258007/10001
7 years, 4 months ago (2013-08-07 12:56:42 UTC) #5
rune
On 2013/08/07 12:46:35, apavlov wrote: > lgtm. > > Could you please re-upload the patch ...
7 years, 4 months ago (2013-08-07 12:57:09 UTC) #6
commit-bot: I haz the power
7 years, 4 months ago (2013-08-07 14:31:10 UTC) #7
Message was sent while issue was closed.
Change committed as 155692

Powered by Google App Engine
This is Rietveld 408576698