Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 22254002: fixes for latest SDK (Closed)

Created:
7 years, 4 months ago by Jennifer Messerly
Modified:
7 years, 4 months ago
CC:
reviews_dartlang.org, web-ui-dev+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/web-ui.git@master
Visibility:
Public.

Description

fixes for latest SDK this is based on changes here: https://codereview.chromium.org/22253002/

Patch Set 1 #

Patch Set 2 : fix comments #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -70 lines) Patch
M example/todomvc/web/app.html View 1 chunk +3 lines, -3 lines 0 comments Download
M example/todomvc/web/editable_label.dart View 1 chunk +6 lines, -21 lines 0 comments Download
M example/todomvc/web/editable_label.html View 1 chunk +3 lines, -4 lines 0 comments Download
M example/todomvc/web/model.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M example/todomvc/web/todo_row.html View 1 chunk +1 line, -1 line 0 comments Download
M lib/polymer.dart View 2 chunks +15 lines, -9 lines 0 comments Download
M lib/polymer_element.dart View 1 5 chunks +35 lines, -27 lines 0 comments Download
M pubspec.yaml View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Jennifer Messerly
also makes fancy-syntax the default
7 years, 4 months ago (2013-08-05 20:10:01 UTC) #1
Siggi Cherem (dart-lang)
lgtm! very very nice! https://chromiumcodereview.appspot.com/22254002/diff/3001/pubspec.yaml File pubspec.yaml (right): https://chromiumcodereview.appspot.com/22254002/diff/3001/pubspec.yaml#newcode10 pubspec.yaml:10: sdk: '>=0.6.13' >=0.6.15
7 years, 4 months ago (2013-08-05 20:24:47 UTC) #2
Jennifer Messerly
https://chromiumcodereview.appspot.com/22254002/diff/3001/pubspec.yaml File pubspec.yaml (right): https://chromiumcodereview.appspot.com/22254002/diff/3001/pubspec.yaml#newcode10 pubspec.yaml:10: sdk: '>=0.6.13' On 2013/08/05 20:24:47, Siggi Cherem (dart-lang) wrote: ...
7 years, 4 months ago (2013-08-05 20:51:57 UTC) #3
Jennifer Messerly
7 years, 4 months ago (2013-08-05 20:52:58 UTC) #4 
On 2013/08/05 20:51:57, John Messerly wrote:
> https://chromiumcodereview.appspot.com/22254002/diff/3001/pubspec.yaml
> File pubspec.yaml (right):
> 
>
https://chromiumcodereview.appspot.com/22254002/diff/3001/pubspec.yaml#newcode10
> pubspec.yaml:10: sdk: '>=0.6.13'
> On 2013/08/05 20:24:47, Siggi Cherem (dart-lang) wrote:
> > >=0.6.15 
> 
> Done.

landed into https://github.com/dart-lang/web-ui/tree/polymer

Powered by Google App Engine
This is Rietveld 408576698