Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4359)

Unified Diff: chrome/browser/signin/signin_browsertest.cc

Issue 22253010: Fix unwanted sign in to Chrome when the user signs in to another service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Back to patch 7 + style fix Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/signin/signin_browsertest.cc
diff --git a/chrome/browser/signin/signin_browsertest.cc b/chrome/browser/signin/signin_browsertest.cc
index aef931c4cf452a0c51a86facd7b7f9235d09012d..1aa32ce9cd559e0d08fa7ab6005ce01d4675eb5e 100644
--- a/chrome/browser/signin/signin_browsertest.cc
+++ b/chrome/browser/signin/signin_browsertest.cc
@@ -207,8 +207,13 @@ IN_PROC_BROWSER_TEST_F(SigninBrowserTest, SigninSkipForNowAndGoBack) {
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
- // Simulate clicking on the Skip for now link by navigating to the URL.
- ui_test_utils::NavigateToURL(browser(), skip_url);
+ // Simulate clicking on the Skip for now link. It's important to have a
+ // link transition so that OneClickSigninHelper removes the blank page
+ // from the history.
+ chrome::NavigateParams navigate_params(browser(),
+ skip_url,
+ content::PAGE_TRANSITION_LINK);
+ ui_test_utils::NavigateToURL(&navigate_params);
// Register an observer that will navigate back immediately on the commit of
// the NTP. This will allow us to hit the race condition of navigating back
« no previous file with comments | « no previous file | chrome/browser/ui/sync/one_click_signin_helper.h » ('j') | chrome/browser/ui/sync/one_click_signin_helper.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698