Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 22253003: Add sadrul@ as an owner of aura and views. (Closed)

Created:
7 years, 4 months ago by Elliot Glaysher
Modified:
7 years, 4 months ago
Reviewers:
sadrul, sky
CC:
chromium-reviews, tfarina, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Add sadrul@ as an owner of aura. Add erg@ as an owner of x11 specific files in aura and views. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215812

Patch Set 1 #

Total comments: 2

Patch Set 2 : Undo changes to chrome/browser/ui/views/OWNERS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M ui/aura/OWNERS View 1 chunk +4 lines, -0 lines 0 comments Download
A ui/views/widget/desktop_aura/OWNERS View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Elliot Glaysher
sky: Added myself to x11 code as we discussed. sadrul: Both sky and ben are ...
7 years, 4 months ago (2013-08-05 20:21:54 UTC) #1
sky
https://codereview.chromium.org/22253003/diff/1/chrome/browser/ui/views/OWNERS File chrome/browser/ui/views/OWNERS (right): https://codereview.chromium.org/22253003/diff/1/chrome/browser/ui/views/OWNERS#newcode4 chrome/browser/ui/views/OWNERS:4: sadrul@chromium.org I don't think Sadrul has done enough with ...
7 years, 4 months ago (2013-08-05 20:23:17 UTC) #2
Elliot Glaysher
ptal https://codereview.chromium.org/22253003/diff/1/chrome/browser/ui/views/OWNERS File chrome/browser/ui/views/OWNERS (right): https://codereview.chromium.org/22253003/diff/1/chrome/browser/ui/views/OWNERS#newcode4 chrome/browser/ui/views/OWNERS:4: sadrul@chromium.org On 2013/08/05 20:23:17, sky wrote: > I ...
7 years, 4 months ago (2013-08-05 21:03:12 UTC) #3
sky
LGTM
7 years, 4 months ago (2013-08-05 21:12:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/22253003/5001
7 years, 4 months ago (2013-08-05 21:21:27 UTC) #5
commit-bot: I haz the power
7 years, 4 months ago (2013-08-06 06:08:53 UTC) #6
Message was sent while issue was closed.
Change committed as 215812

Powered by Google App Engine
This is Rietveld 408576698