[Android] Make it possible to show Infobar in native pages

[Android] Make it possible to show Infobar in native pages

This CL enables Chrome to show infobar in native pages, especially in
the NTP. From now on, Tab.getView() will always return the wrapper that
holds both infobar container and the tab's content, which could be a
native page or a content view, rendered by blink/compositor.

BUG=508307
TBR=tedchoc@chromium.org

Committed: https://crrev.com/6943a9a92a909bb927080ef6c7658ddbce3a3ae7
Cr-Commit-Position: refs/heads/master@{#410996}

[Ian Wen, 2016-08-08 22:02:39]

ianwen@chromium.org changed reviewers:
+ dfalcantara@chromium.org, tedchoc@chromium.org

[Ian Wen, 2016-08-08 22:02:40]

PTAL.

Added Ted as he once worked on a similar CL.

[Ian Wen, 2016-08-08 22:11:05]

The CQ bit was checked by ianwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 22:11:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gone, 2016-08-08 22:49:55]

https://chromiumcodereview.appspot.com/2224853003/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/tab/TabContentViewParent.java
(right):

https://chromiumcodereview.appspot.com/2224853003/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/tab/TabContentViewParent.java:38:
addView(viewToShow, 0);
Should pull out 0 as a constant so that it's explicit

[commit-bot: I haz the power, 2016-08-08 23:34:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 23:34:25]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ian Wen, 2016-08-09 00:30:59]

The CQ bit was checked by ianwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 00:31:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 01:57:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 01:57:06]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ian Wen, 2016-08-09 22:48:39]

The CQ bit was checked by ianwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 22:49:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gone, 2016-08-10 00:32:06]

lgtm

[commit-bot: I haz the power, 2016-08-10 00:37:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 00:37:10]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ian Wen, 2016-08-10 06:57:04]

Description was changed from

==========
[Android] Make it possible to show Infobar in native pages

This CL enables Chrome to show infobar in native pages, especially in
the NTP. From now on, Tab.getView() will always return the wrapper that
holds both infobar container and the tab's content, which could be a
native page or a content view, rendered by blink/compositor.

BUG=508307
==========

to

==========
[Android] Make it possible to show Infobar in native pages

This CL enables Chrome to show infobar in native pages, especially in
the NTP. From now on, Tab.getView() will always return the wrapper that
holds both infobar container and the tab's content, which could be a
native page or a content view, rendered by blink/compositor.

BUG=508307
TBR=tedchoc@chromium.org
==========

[Ian Wen, 2016-08-10 06:57:12]

The CQ bit was checked by ianwen@chromium.org

[Ian Wen, 2016-08-10 06:57:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2224853003/#ps60001
(title: "fix focus problem")

[commit-bot: I haz the power, 2016-08-10 06:57:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 07:38:11]

Description was changed from

==========
[Android] Make it possible to show Infobar in native pages

This CL enables Chrome to show infobar in native pages, especially in
the NTP. From now on, Tab.getView() will always return the wrapper that
holds both infobar container and the tab's content, which could be a
native page or a content view, rendered by blink/compositor.

BUG=508307
TBR=tedchoc@chromium.org
==========

to

==========
[Android] Make it possible to show Infobar in native pages

This CL enables Chrome to show infobar in native pages, especially in
the NTP. From now on, Tab.getView() will always return the wrapper that
holds both infobar container and the tab's content, which could be a
native page or a content view, rendered by blink/compositor.

BUG=508307
TBR=tedchoc@chromium.org
==========

[commit-bot: I haz the power, 2016-08-10 07:38:13]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-10 07:41:08]

Description was changed from

==========
[Android] Make it possible to show Infobar in native pages

This CL enables Chrome to show infobar in native pages, especially in
the NTP. From now on, Tab.getView() will always return the wrapper that
holds both infobar container and the tab's content, which could be a
native page or a content view, rendered by blink/compositor.

BUG=508307
TBR=tedchoc@chromium.org
==========

to

==========
[Android] Make it possible to show Infobar in native pages

This CL enables Chrome to show infobar in native pages, especially in
the NTP. From now on, Tab.getView() will always return the wrapper that
holds both infobar container and the tab's content, which could be a
native page or a content view, rendered by blink/compositor.

BUG=508307
TBR=tedchoc@chromium.org

Committed: https://crrev.com/6943a9a92a909bb927080ef6c7658ddbce3a3ae7
Cr-Commit-Position: refs/heads/master@{#410996}
==========

[commit-bot: I haz the power, 2016-08-10 07:41:09]

Patchset 4 (id:??) landed as
https://crrev.com/6943a9a92a909bb927080ef6c7658ddbce3a3ae7
Cr-Commit-Position: refs/heads/master@{#410996}

[huangs, 2016-08-10 15:22:35]

This might be causing regression in
org.chromium.chrome.browser.TabsTest#testCloseFiveIncognitoTabLandscape
org.chromium.chrome.browser.TabsTest#testCloseFiveIncognitoTabPortrait

https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg...

Going to revert to see if this fixes things.

[huangs, 2016-08-10 15:25:15]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2232943002/ by huangs@chromium.org.

The reason for reverting is:
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg...

This CL may have caused new test failures in Android Tests:
org.chromium.chrome.browser.TabsTest#testCloseFiveIncognitoTabLandscape
org.chromium.chrome.browser.TabsTest#testCloseFiveIncognitoTabPortrait.