Keep the top-of-window views revealed when clicking on the top-of-window views with a bubble open

Keep the top-of-window views revealed when clicking on the top-of-window views with a bubble open.

BUG=268457
TEST=ImmersiveModeControllerAshTest.Bubbles

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216877

[pkotwicz, 2013-08-05 19:14:07]

James, PTAL

https://codereview.chromium.org/22238003/diff/5001/chrome/browser/ui/views/fr...
File chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc (left):

https://codereview.chromium.org/22238003/diff/5001/chrome/browser/ui/views/fr...
chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc:491:
UpdateLocatedEventRevealedLock(NULL);
This is no longer necessary given that it is now ok to update the
|located_event_revealed_lock_| slightly after the top-of-window views have
started unrevealing.
Bubbles are also way more common than transient windows. (So the amount of
scenarios where this code would have avoided a couple extra layout calls is
minimal)

[James Cook, 2013-08-06 23:32:42]

LGTM with some comment nits

https://codereview.chromium.org/22238003/diff/5001/chrome/browser/ui/views/fr...
File chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc (right):

https://codereview.chromium.org/22238003/diff/5001/chrome/browser/ui/views/fr...
chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc:510: //
BubbleManager::UpdateRevealedLock() because |widget| is not yet activate
activate -> activated

https://codereview.chromium.org/22238003/diff/5001/chrome/browser/ui/views/fr...
File chrome/browser/ui/views/frame/immersive_mode_controller_ash.h (right):

https://codereview.chromium.org/22238003/diff/5001/chrome/browser/ui/views/fr...
chrome/browser/ui/views/frame/immersive_mode_controller_ash.h:136: enum
RevealWhileClosing {
Document what these mean.  Also, I find the name a little confusing.  Does this
mean "allow a reveal while closing"?

[commit-bot: I haz the power, 2013-08-09 18:31:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/22238003/22001

[commit-bot: I haz the power, 2013-08-10 03:31:04]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-08-10 15:24:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/22238003/22001

[commit-bot: I haz the power, 2013-08-10 16:24:37]

Change committed as 216877