Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 2221713002: Make memlock less verbose. (Closed)

Created:
4 years, 4 months ago by iannucci
Modified:
4 years, 4 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, andrew.wang, todd, tandrii+luci-go_chromium.org, M-A Ruel
Base URL:
https://chromium.googlesource.com/external/github.com/luci/luci-go@master
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Make memlock less verbose. This way the logging fields don't leak into the user's logging code. R=vadimsh@chromium.org BUG= Committed: https://github.com/luci/luci-go/commit/35fb49196f4557ca5ad22ed86c568fd998b49edf

Patch Set 1 #

Patch Set 2 : Fix process test in tumble #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M appengine/memlock/memlock.go View 1 chunk +5 lines, -3 lines 0 comments Download
M tumble/process_test.go View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
iannucci
4 years, 4 months ago (2016-08-06 10:02:26 UTC) #1
Vadim Sh.
lgtm you mentioned me in R= line twice, I'm flattered :)
4 years, 4 months ago (2016-08-06 17:23:57 UTC) #2
iannucci
On 2016/08/06 17:23:57, Vadim Sh. wrote: > lgtm > > you mentioned me in R= ...
4 years, 4 months ago (2016-08-06 18:35:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2221713002/1
4 years, 4 months ago (2016-08-06 18:35:31 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Luci-go Linux Precise 32 Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/3079f53b70f12410) ...
4 years, 4 months ago (2016-08-06 18:39:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2221713002/20001
4 years, 4 months ago (2016-08-06 18:43:41 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-06 18:57:19 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/35fb49196f4557ca5ad22ed86c568fd998b49edf

Powered by Google App Engine
This is Rietveld 408576698