Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 22213002: Replace LoadNamedFieldPolymorphic with explicit branches. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-ia32.h ('k') | src/x64/lithium-codegen-x64.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2174 matching lines...) Expand 10 before | Expand all | Expand 10 after
2185 2185
2186 LInstruction* LChunkBuilder::DoLoadNamedField(HLoadNamedField* instr) { 2186 LInstruction* LChunkBuilder::DoLoadNamedField(HLoadNamedField* instr) {
2187 LOperand* obj = (instr->access().IsExternalMemory() && 2187 LOperand* obj = (instr->access().IsExternalMemory() &&
2188 instr->access().offset() == 0) 2188 instr->access().offset() == 0)
2189 ? UseRegisterOrConstantAtStart(instr->object()) 2189 ? UseRegisterOrConstantAtStart(instr->object())
2190 : UseRegisterAtStart(instr->object()); 2190 : UseRegisterAtStart(instr->object());
2191 return DefineAsRegister(new(zone()) LLoadNamedField(obj)); 2191 return DefineAsRegister(new(zone()) LLoadNamedField(obj));
2192 } 2192 }
2193 2193
2194 2194
2195 LInstruction* LChunkBuilder::DoLoadNamedFieldPolymorphic(
2196 HLoadNamedFieldPolymorphic* instr) {
2197 ASSERT(instr->representation().IsTagged());
2198 if (instr->need_generic()) {
2199 LOperand* context = UseFixed(instr->context(), esi);
2200 LOperand* obj = UseFixed(instr->object(), edx);
2201 LLoadNamedFieldPolymorphic* result =
2202 new(zone()) LLoadNamedFieldPolymorphic(context, obj);
2203 return MarkAsCall(DefineFixed(result, eax), instr);
2204 } else {
2205 LOperand* context = UseAny(instr->context()); // Not actually used.
2206 LOperand* obj = UseRegisterAtStart(instr->object());
2207 LLoadNamedFieldPolymorphic* result =
2208 new(zone()) LLoadNamedFieldPolymorphic(context, obj);
2209 return AssignEnvironment(DefineAsRegister(result));
2210 }
2211 }
2212
2213
2214 LInstruction* LChunkBuilder::DoLoadNamedGeneric(HLoadNamedGeneric* instr) { 2195 LInstruction* LChunkBuilder::DoLoadNamedGeneric(HLoadNamedGeneric* instr) {
2215 LOperand* context = UseFixed(instr->context(), esi); 2196 LOperand* context = UseFixed(instr->context(), esi);
2216 LOperand* object = UseFixed(instr->object(), edx); 2197 LOperand* object = UseFixed(instr->object(), edx);
2217 LLoadNamedGeneric* result = new(zone()) LLoadNamedGeneric(context, object); 2198 LLoadNamedGeneric* result = new(zone()) LLoadNamedGeneric(context, object);
2218 return MarkAsCall(DefineFixed(result, eax), instr); 2199 return MarkAsCall(DefineFixed(result, eax), instr);
2219 } 2200 }
2220 2201
2221 2202
2222 LInstruction* LChunkBuilder::DoLoadFunctionPrototype( 2203 LInstruction* LChunkBuilder::DoLoadFunctionPrototype(
2223 HLoadFunctionPrototype* instr) { 2204 HLoadFunctionPrototype* instr) {
(...skipping 507 matching lines...) Expand 10 before | Expand all | Expand 10 after
2731 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2712 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2732 LOperand* object = UseRegister(instr->object()); 2713 LOperand* object = UseRegister(instr->object());
2733 LOperand* index = UseTempRegister(instr->index()); 2714 LOperand* index = UseTempRegister(instr->index());
2734 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2715 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2735 } 2716 }
2736 2717
2737 2718
2738 } } // namespace v8::internal 2719 } } // namespace v8::internal
2739 2720
2740 #endif // V8_TARGET_ARCH_IA32 2721 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/lithium-ia32.h ('k') | src/x64/lithium-codegen-x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698