Replace LoadNamedFieldPolymorphic with explicit branches.

Replace LoadNamedFieldPolymorphic with explicit branches.

R=ulan@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=16133

[Toon Verwaest, 2013-08-05 17:49:55]

PTAL

[ulan, 2013-08-06 13:36:24]

https://chromiumcodereview.appspot.com/22213002/diff/11001/src/hydrogen.cc
File src/hydrogen.cc (right):

https://chromiumcodereview.appspot.com/22213002/diff/11001/src/hydrogen.cc#ne...
src/hydrogen.cc:4658: NoObservableSideEffectsScope no_side_effects(this);
Shouldn't this be in its own scope (i.e. surrounded by {}). Otherwise, I think
it would affect the if branch above too.

https://chromiumcodereview.appspot.com/22213002/diff/11001/src/hydrogen.cc#ne...
src/hydrogen.cc:4720: HInstruction* load = BuildLoadNamedGeneric(object, name,
expr);
Why it is in NoObservableSideEffectsScope scope?

[Toon Verwaest, 2013-08-06 14:03:44]

Addressed comment.

https://chromiumcodereview.appspot.com/22213002/diff/11001/src/hydrogen.cc
File src/hydrogen.cc (right):

https://chromiumcodereview.appspot.com/22213002/diff/11001/src/hydrogen.cc#ne...
src/hydrogen.cc:4720: HInstruction* load = BuildLoadNamedGeneric(object, name,
expr);
Scary premature optimization attempt. Removed :)

On 2013/08/06 13:36:24, ulan wrote:
> Why it is in NoObservableSideEffectsScope scope?

[ulan, 2013-08-09 14:00:13]

LGTM

[Toon Verwaest, 2013-08-09 14:04:57]

Committed patchset #4 manually as r16133 (presubmit successful).