src/debug.cc - Issue 22198002: Fix step in positions (include various calls and exclude current pc point), add a test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug.cc

Issue 22198002: Fix step in positions (include various calls and exclude current pc point), add a test (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: comment Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/debug.cc

diff --git a/src/debug.cc b/src/debug.cc

index a0b9884410f289302d7d74be6e65bfb62ef1a413..05c207f16a9cd86bb0ed6a4b29b93653c4b6b948 100644

--- a/src/debug.cc

+++ b/src/debug.cc

@@ -410,6 +410,9 @@ bool BreakLocationIterator::IsStepInLocation(Isolate* isolate) {

HandleScope scope(debug_info_->GetIsolate());

Address target = rinfo()->target_address();

Handle<Code> target_code(Code::GetCodeFromTargetAddress(target));

+ if (target_code->kind() == Code::STUB) {

+ return target_code->major_key() == CodeStub::CallFunction;

+ }

return target_code->is_call_stub() || target_code->is_keyed_call_stub();

} else {

return false;

« no previous file with comments | « no previous file | src/execution.cc » ('j') | test/mjsunit/debug-stepin-positions.js » ('J')