Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: chrome/browser/extensions/api/developer_private/developer_private_api.cc

Issue 22191003: [Apps Developer Tool] Show installation warnings as chrome://extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update as comments. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/apps_debugger/css/items.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/developer_private/developer_private_api.cc
diff --git a/chrome/browser/extensions/api/developer_private/developer_private_api.cc b/chrome/browser/extensions/api/developer_private/developer_private_api.cc
index b6c766ac7cce0a6ae90a5b0aa8f524252bee798c..d5bd6ea45f3e3a335d30ca4d2bc3407c5a72c69a 100644
--- a/chrome/browser/extensions/api/developer_private/developer_private_api.cc
+++ b/chrome/browser/extensions/api/developer_private/developer_private_api.cc
@@ -53,6 +53,7 @@
#include "extensions/browser/view_type_utils.h"
#include "extensions/common/constants.h"
#include "extensions/common/extension_resource.h"
+#include "extensions/common/install_warning.h"
#include "extensions/common/switches.h"
#include "grit/chromium_strings.h"
#include "grit/generated_resources.h"
@@ -299,6 +300,14 @@ scoped_ptr<developer::ItemInfo>
if (Manifest::IsUnpackedLocation(item.location())) {
info->path.reset(
new std::string(UTF16ToUTF8(item.path().LossyDisplayName())));
+ for (std::vector<extensions::InstallWarning>::const_iterator it =
+ item.install_warnings().begin();
+ it != item.install_warnings().end(); ++it) {
+ developer::InstallWarning* warning = new developer::InstallWarning();
+ warning->is_html = (it->format == InstallWarning::FORMAT_HTML);
+ warning->message = it->message;
+ info->install_warnings.push_back(make_linked_ptr(warning));
+ }
}
info->incognito_enabled = service->IsIncognitoEnabled(item.id());
« no previous file with comments | « no previous file | chrome/browser/resources/apps_debugger/css/items.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698