net/socket/tcp_client_socket_win.h - Issue 22188002: Cleanup the Win overlapped reads vs. non-blocking reads by removing the overlapped read code path

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/tcp_client_socket_win.h

Issue 22188002: Cleanup the Win overlapped reads vs. non-blocking reads by removing the overlapped read code path (Closed) Base URL: https://src.chromium.org/chrome/trunk/src/

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/socket/tcp_client_socket_win.h

===================================================================

--- net/socket/tcp_client_socket_win.h (revision 215603)

+++ net/socket/tcp_client_socket_win.h (working copy)

@@ -70,10 +70,6 @@

virtual bool SetKeepAlive(bool enable, int delay);

virtual bool SetNoDelay(bool no_delay);

- // Perform reads in non-blocking mode instead of overlapped mode.

- // Used for experiments.

- static void DisableOverlappedReads();

private:

// State machine for connecting the socket.

enum ConnectState {

@@ -105,7 +101,6 @@

void DoReadCallback(int rv);

void DoWriteCallback(int rv);

void DidCompleteConnect();

- void DidCompleteRead();

void DidCompleteWrite();

void DidSignalRead();

« no previous file with comments | « chrome/renderer/page_load_histograms.cc ('k') | net/socket/tcp_client_socket_win.cc » ('j') | no next file with comments »