Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: chrome/browser/android/shortcut_helper.h

Issue 2218413002: Calls ShortcutHelper::FinalizeLauncherIcon() on worker thread instead of on IO thread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge branch 'master' into webapk_builder_impl2_thread0 Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/shortcut_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/shortcut_helper.h
diff --git a/chrome/browser/android/shortcut_helper.h b/chrome/browser/android/shortcut_helper.h
index c41bba646d2bc503cf17410f3c9e7e43f45803e7..f24995dffcb498b862b1253665a6b640d85dce9a 100644
--- a/chrome/browser/android/shortcut_helper.h
+++ b/chrome/browser/android/shortcut_helper.h
@@ -102,9 +102,10 @@ class ShortcutHelper {
// Returns the given icon, modified to match the launcher requirements.
// This method may generate an entirely new icon; if this is the case,
// |is_generated| will be set to |true|.
- static SkBitmap FinalizeLauncherIcon(const SkBitmap& icon,
- const GURL& url,
- bool* is_generated);
+ // Must be called on a background worker thread.
+ static SkBitmap FinalizeLauncherIconInBackground(const SkBitmap& icon,
+ const GURL& url,
+ bool* is_generated);
// Returns true if WebAPKs are enabled and there is a WebAPK installed which
// can handle |url|.
« no previous file with comments | « no previous file | chrome/browser/android/shortcut_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698