Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1237)

Unified Diff: chrome/browser/android/shortcut_helper.h

Issue 2218413002: Calls ShortcutHelper::FinalizeLauncherIcon() on worker thread instead of on IO thread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/shortcut_helper.h
diff --git a/chrome/browser/android/shortcut_helper.h b/chrome/browser/android/shortcut_helper.h
index 8f489d358038f65f37b2e4b9dd89cc9022405bcd..c16283d0f41da6d12e015d567aeac134b0913420 100644
--- a/chrome/browser/android/shortcut_helper.h
+++ b/chrome/browser/android/shortcut_helper.h
@@ -102,9 +102,10 @@ class ShortcutHelper {
// Returns the given icon, modified to match the launcher requirements.
// This method may generate an entirely new icon; if this is the case,
// |is_generated| will be set to |true|.
- static SkBitmap FinalizeLauncherIcon(const SkBitmap& icon,
- const GURL& url,
- bool* is_generated);
+ // Must not be called on the UI thread.
dominickn 2016/08/08 03:13:41 Nit: "Must be called on a background worker thread
+ static SkBitmap FinalizeLauncherIconInBackground(const SkBitmap& icon,
+ const GURL& url,
+ bool* is_generated);
// Returns true if WebAPKs are enabled and there is a WebAPK installed which
// can handle |url|.

Powered by Google App Engine
This is Rietveld 408576698