Accessibility strings for app install alerts

chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerView.java

Index: chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerView.java b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerView.java
index 9345693824256146903a5939f53024940756e817..8f7f66917b673165f526f395b2a103f5d2dc65bd 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerView.java
@@ -36,6 +36,8 @@ import org.chromium.ui.base.LocalizationUtils;
 import org.chromium.ui.base.WindowAndroid;
 import org.chromium.ui.base.WindowAndroid.IntentCallback;
 
+import java.util.Locale;
+
 /**
  * Lays out a banner for showing info about an app on the Play Store.
  * The banner mimics the appearance of a Google Now card using a background Drawable with a shadow.
@@ -242,6 +244,7 @@ public class AppBannerView extends SwipableOverlayView
         mTitleView.setText(mAppData.title());
         mIconView.setImageDrawable(mAppData.icon());
         mRatingView.initialize(mAppData.rating());
+        setAccessibilityInformation();
 
         // Determine how much the user can drag sideways before their touch is considered a scroll.
         mTouchSlop = ViewConfiguration.get(getContext()).getScaledTouchSlop();
@@ -250,6 +253,16 @@ public class AppBannerView extends SwipableOverlayView
         updateButtonAppearance();
     }
 
+    /**
+     * Creates a succinct description about the app being advertised.
+     */
+    private void setAccessibilityInformation() {
+        String bannerTemplate = getContext().getString(R.string.app_banner_view_accessibility);

[newt (away), 2014/04/02 22:51:20]

even simpler:

    String bannerText =
getResources().getString(R.string.app_banner_view_accessibility,
            mAppData.title(), mAppData.rating());

[gone, 2014/04/02 23:13:12]

Done.

+        String bannerText = String.format(
+                Locale.getDefault(), bannerTemplate, mAppData.title(), mAppData.rating());
+        setContentDescription(bannerText);
+    }
+
     @Override
     public void onClick(View view) {
         if (mObserver == null) return;
@@ -431,6 +444,8 @@ public class AppBannerView extends SwipableOverlayView
             fgColor = res.getColor(R.color.app_banner_install_button_fg);
             if (mInstallState == INSTALL_STATE_NOT_INSTALLED) {
                 text = mAppData.installButtonText();
+                mInstallButtonView.setContentDescription(
+                        getContext().getString(R.string.app_banner_install_accessibility, text));
             } else {
                 text = res.getString(R.string.app_banner_installing);
             }