Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1112)

Unified Diff: chrome/browser/chromeos/login/managed/managed_user_creation_controller_new.cc

Issue 221813006: Various supervised user password fixes - 2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix comments Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/managed/supervised_user_authentication.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/managed/managed_user_creation_controller_new.cc
diff --git a/chrome/browser/chromeos/login/managed/managed_user_creation_controller_new.cc b/chrome/browser/chromeos/login/managed/managed_user_creation_controller_new.cc
index b9eaca0d5ca21b96777afc8890587119695e8264..06cf6f43d577930f00880470fe476c7875c868a5 100644
--- a/chrome/browser/chromeos/login/managed/managed_user_creation_controller_new.cc
+++ b/chrome/browser/chromeos/login/managed/managed_user_creation_controller_new.cc
@@ -136,7 +136,7 @@ void ManagedUserCreationControllerNew::StartImport(
void ManagedUserCreationControllerNew::StartCreationImpl() {
DCHECK(creation_context_);
- DCHECK(stage_ == STAGE_INITIAL);
+ DCHECK_EQ(STAGE_INITIAL, stage_);
VLOG(1) << "Starting supervised user creation";
VLOG(1) << " Phase 1 : Prepare keys";
@@ -249,7 +249,7 @@ void ManagedUserCreationControllerNew::OnAuthenticationFailure(
void ManagedUserCreationControllerNew::OnMountSuccess(
const std::string& mount_hash) {
DCHECK(creation_context_);
- DCHECK(stage_ == KEYS_GENERATED);
+ DCHECK_EQ(KEYS_GENERATED, stage_);
VLOG(1) << " Phase 2.2 : Created home dir with master key";
creation_context_->mount_hash = mount_hash;
@@ -281,7 +281,7 @@ void ManagedUserCreationControllerNew::OnMountSuccess(
void ManagedUserCreationControllerNew::OnAddKeySuccess() {
DCHECK(creation_context_);
- DCHECK(stage_ == KEYS_GENERATED);
+ DCHECK_EQ(KEYS_GENERATED, stage_);
stage_ = CRYPTOHOME_CREATED;
VLOG(1) << " Phase 3 : Create/update user on chrome.com/manage";
@@ -319,7 +319,7 @@ void ManagedUserCreationControllerNew::RegistrationCallback(
const GoogleServiceAuthError& error,
const std::string& token) {
DCHECK(creation_context_);
- DCHECK(stage_ == CRYPTOHOME_CREATED);
+ DCHECK_EQ(CRYPTOHOME_CREATED, stage_);
stage_ = DASHBOARD_CREATED;
@@ -344,7 +344,7 @@ void ManagedUserCreationControllerNew::RegistrationCallback(
void ManagedUserCreationControllerNew::OnManagedUserFilesStored(bool success) {
DCHECK(creation_context_);
- DCHECK(stage_ == DASHBOARD_CREATED);
+ DCHECK_EQ(DASHBOARD_CREATED, stage_);
if (!success) {
stage_ = STAGE_ERROR;
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/managed/supervised_user_authentication.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698