Remove fileBrowserPrivate.transferFile.

Remove fileBrowserPrivate.transferFile.

We removed the invocation of the method, so we no longer need it.
This CL removes it.

BUG=258311
TEST=Ran browser_tests --gtest_filter="*FileSystemExtensionApiTest*:*FileManagerBrowserTest*" and unit_tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215971

[hidehiko, 2013-08-05 11:17:37]

Thank you for your review in advance,
- hidehiko

[kinaba, 2013-08-05 11:53:46]

Please also change
chrome/browser/extensions/extension_function_histogram_value.h.
(See the comment "2) Deleting an existing function:" there.)

[hidehiko, 2013-08-05 17:31:48]

Thank you for your review.
Fixed enums. PTAL?
-hidehiko

[mtomasz, 2013-08-05 17:35:46]

lgtm

[kinaba, 2013-08-06 00:30:57]

lgtm

[satorux1, 2013-08-06 01:29:09]

LGTM. You need approval from asagent for
chrome/common/extensions/api/file_browser_private.json.

I guess it's safe to TBR as this change just deletes a private API function.

https://codereview.chromium.org/22181002/diff/7001/tools/metrics/histograms/h...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/22181002/diff/7001/tools/metrics/histograms/h...
tools/metrics/histograms/histograms.xml:17131: <int value="341"
label="DELETED_FILEBROWSERPRIVATE_TRANSFERFILE"/>
I think you don't need to touch this. The comment above said:

<!-- Generated from ../../../chrome/browser/extensions/extension_function_histog
       ram_value.h -->

[hidehiko, 2013-08-06 01:41:45]

Ilya, could you review tools/metrics/histogram/histograms.xml as an OWNER?
Antony, could you review chrome/common/extensions/api/file_browser_private.json?

I also think this is safe to TBR, but this is my first CL to edit API related
code, so pls let me have a regular code review cycle just in case.

Thanks,
- hidehiko

https://codereview.chromium.org/22181002/diff/7001/tools/metrics/histograms/h...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/22181002/diff/7001/tools/metrics/histograms/h...
tools/metrics/histograms/histograms.xml:17131: <int value="341"
label="DELETED_FILEBROWSERPRIVATE_TRANSFERFILE"/>
On 2013/08/06 01:29:09, satorux1 wrote:
> I think you don't need to touch this. The comment above said:
> 
> <!-- Generated from
../../../chrome/browser/extensions/extension_function_histog
>        ram_value.h -->

According to the change history, it seems we need to manually edit this?

[Ilya Sherman, 2013-08-06 06:51:22]

histograms.xml lgtm

[asargent_no_longer_on_chrome, 2013-08-06 17:11:18]

lgtm

[commit-bot: I haz the power, 2013-08-06 18:35:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hidehiko@chromium.org/22181002/7001

[commit-bot: I haz the power, 2013-08-06 21:00:29]

Change committed as 215971