Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2217573002: bluetooth: Only add new devices, connected devices and devices that changed. (Closed)

Created:
4 years, 4 months ago by ortuno
Modified:
4 years, 4 months ago
Reviewers:
scheib
CC:
chromium-reviews, darin-cc_chromium.org, jam, ortuno+watch_chromium.org, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@bluetooth-add-or-update
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Only add new devices, connected devices and devices that changed. Last of three patches to improve devices in the chooser: [1] Replace old advertised uuids (http://crrev.com/2205693003) [2] Allow updates on chooser items (http://crrev.com/2210873003) [3] This patch BUG=508904 Committed: https://crrev.com/7992351858fe9bb262e18527c590bbb301243b61 Cr-Commit-Position: refs/heads/master@{#410983}

Patch Set 1 #

Patch Set 2 : Fix mocks and tests. Still missing more test. #

Patch Set 3 : Add ALL the tests! #

Patch Set 4 : Forgot to add a test #

Patch Set 5 : Rebase #

Total comments: 2

Patch Set 6 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+341 lines, -216 lines) Patch
M content/browser/bluetooth/bluetooth_device_chooser_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/bluetooth/bluetooth_device_chooser_controller.cc View 1 2 3 4 5 4 chunks +6 lines, -7 lines 0 comments Download
M content/browser/bluetooth/web_bluetooth_service_impl.cc View 1 2 3 4 5 3 chunks +9 lines, -2 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h View 1 2 3 4 5 2 chunks +38 lines, -1 line 0 comments Download
M content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc View 1 2 8 chunks +108 lines, -7 lines 0 comments Download
M device/bluetooth/test/mock_bluetooth_device.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M device/bluetooth/test/mock_bluetooth_device.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/consecutive-calls.html View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/multiple-matching-devices.html View 1 2 2 chunks +8 lines, -8 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/new-scan-all-types.html View 1 2 1 chunk +39 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/new-scan-connected-devices.html View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/new-scan-device-added.html View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/new-scan-device-changed.html View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/new-scan-services-discovered.html View 1 2 3 1 chunk +26 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/restart-scan-finds-new-device.html View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/restart-scan-includes-previous-device.html View 1 2 3 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/requestDevice/consecutive-calls.html View 1 2 1 chunk +0 lines, -47 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/requestDevice/multiple-matching-devices.html View 1 2 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/requestDevice/restart-scan-finds-new-device.html View 1 2 1 chunk +0 lines, -42 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/requestDevice/restart-scan-includes-previous-device.html View 1 2 1 chunk +0 lines, -45 lines 0 comments Download
M third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js View 1 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 24 (18 generated)
ortuno
scheib: PTAL
4 years, 4 months ago (2016-08-08 23:23:16 UTC) #7
scheib
LGTM https://codereview.chromium.org/2217573002/diff/80001/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h File content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h (right): https://codereview.chromium.org/2217573002/diff/80001/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h#newcode163 content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h:163: // - No UUIDs (A Generic Access UUID ...
4 years, 4 months ago (2016-08-09 20:33:43 UTC) #12
ortuno
Thanks! https://codereview.chromium.org/2217573002/diff/80001/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h File content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h (right): https://codereview.chromium.org/2217573002/diff/80001/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h#newcode163 content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h:163: // - No UUIDs (A Generic Access UUID ...
4 years, 4 months ago (2016-08-09 22:03:45 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2217573002/100001
4 years, 4 months ago (2016-08-10 05:09:30 UTC) #21
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 4 months ago (2016-08-10 06:41:50 UTC) #22
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 06:43:11 UTC) #24
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/7992351858fe9bb262e18527c590bbb301243b61
Cr-Commit-Position: refs/heads/master@{#410983}

Powered by Google App Engine
This is Rietveld 408576698