Issue 22173002: Fix a crash on stroking empty paths with nv_path_rendering enabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22173002: Fix a crash on stroking empty paths with nv_path_rendering enabled (Closed)

Created:
7 years, 4 months ago by Kimmo Kinnunen

Modified:
7 years, 4 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Fix a crash on stroking empty paths with nv_path_rendering enabled Fix the crash by defining that GrPathRenderer::drawPath and GrPathRenderer::stencilPath are called only with non-empty paths. Adds a new test "GpuDrawPath" and tests the condition. BUG=skia:1477 Committed: http://code.google.com/p/skia/source/detail?r=10528

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+105 lines, -9 lines)			Patch
M	gyp/tests.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/gpu/GrClipMaskManager.cpp	View	1 chunk	+7 lines, -5 lines	0 comments	Download
M	src/gpu/GrContext.cpp	View	5 chunks	+12 lines, -0 lines	0 comments	Download
M	src/gpu/GrPathRenderer.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/gpu/gl/GrGLPath.cpp	View	1 chunk	+5 lines, -4 lines	0 comments	Download
A	tests/GpuDrawPathTest.cpp	View	1 chunk	+78 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kkinnunen@nvidia.com/22173002/1

7 years, 4 months ago (2013-08-05 13:17:44 UTC) #3

Message was sent while issue was closed.

Change committed as 10528

Expand Messages | Collapse Messages