Issue 22171002: Avoid counting verbs twice in SkPath::isEmpty()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22171002: Avoid counting verbs twice in SkPath::isEmpty() (Closed)

Created:
7 years, 4 months ago by Kimmo Kinnunen

Modified:
7 years, 4 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Avoid counting verbs twice in SkPath::isEmpty() Remove redundant call to SkPathRef::countVerbs. The intention was probably to count points. Instead, assert that all two-verb paths begin with a 'move' and that if the second verb is a 'line', then the point count is indeed two. BUG=skia:1478 Committed: http://code.google.com/p/skia/source/detail?r=10527

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	src/core/SkPath.cpp	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kkinnunen@nvidia.com/22171002/1

7 years, 4 months ago (2013-08-05 13:16:05 UTC) #3

rmistry

7 years, 4 months ago (2013-08-05 13:32:54 UTC) #5

Message was sent while issue was closed.

On 2013/08/05 13:23:16, I haz the power (commit-bot) wrote:
> Change committed as 10527

FYI: Using "BUG=skia:1478" instead of "BUG=1478" will point to the skia bug.

Expand Messages | Collapse Messages