ui/webui/resources/js/cr/ui/context_menu_handler.js - Issue 22154002: Not to show context menu if there are no visible items to show.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/js/cr/ui/context_menu_handler.js

Issue 22154002: Not to show context menu if there are no visible items to show. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: addressed comment Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/webui/resources/js/cr/ui/context_menu_handler.js

diff --git a/ui/webui/resources/js/cr/ui/context_menu_handler.js b/ui/webui/resources/js/cr/ui/context_menu_handler.js

index 30ab13c695e77f11a05345d62ba5082689ffd4a8..05264d6ee3b7dbb2a29635fcff7071e8027e1c23 100644

--- a/ui/webui/resources/js/cr/ui/context_menu_handler.js

+++ b/ui/webui/resources/js/cr/ui/context_menu_handler.js

@@ -35,8 +35,11 @@ cr.define('cr.ui', function() {

* @param {!cr.ui.Menu} menu The menu to show.

showMenu: function(e, menu) {

- this.menu_ = menu;

menu.updateCommands(e.currentTarget);

+ if (!menu.hasVisibleItems())

+ return;

+ this.menu_ = menu;

menu.classList.remove('hide-delayed');

menu.hidden = false;

menu.contextElement = e.currentTarget;

« no previous file with comments | « no previous file | ui/webui/resources/js/cr/ui/menu.js » ('j') | no next file with comments »