Re-implement cancellation of copyFileEntry_().

Re-implement cancellation of copyFileEntry_().

Currently, copyFileEntry_ depends on FileCopyOperation.maybeCancel. This CL
removes it, instead copyFileEntry_ starts to return a callback to cancel the
on going operation.
Also, this CL adds some missing cancellation handling in copyFileEntry_().

BUG=246976
TEST=Ran browser_tests --gtest_filter="*FileSystemExtensionApiTest*:*FileManagerBrowserTest*" and tested manually.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215820

[hidehiko, 2013-08-05 08:33:12]

Thank you for your review in advance,
- hidehiko

[mtomasz, 2013-08-06 01:39:19]

The new cancellation is awesome!

https://codereview.chromium.org/22150006/diff/3001/chrome/browser/resources/f...
File chrome/browser/resources/file_manager/js/file_copy_manager.js (right):

https://codereview.chromium.org/22150006/diff/3001/chrome/browser/resources/f...
chrome/browser/resources/file_manager/js/file_copy_manager.js:487:
this.cancelRequested_ = true;
Can we remove this member and just clean the callback after #489?

https://codereview.chromium.org/22150006/diff/3001/chrome/browser/resources/f...
chrome/browser/resources/file_manager/js/file_copy_manager.js:1023:
errorCallback(util.createFileError(FileError.ABORT_ERR));
Can we remove the target file on cancel? It may be completely broken. I don't
think anyone would want it.

[hidehiko, 2013-08-06 02:14:55]

Thank you for your review. PTAL?

https://codereview.chromium.org/22150006/diff/3001/chrome/browser/resources/f...
File chrome/browser/resources/file_manager/js/file_copy_manager.js (right):

https://codereview.chromium.org/22150006/diff/3001/chrome/browser/resources/f...
chrome/browser/resources/file_manager/js/file_copy_manager.js:487:
this.cancelRequested_ = true;
On 2013/08/06 01:39:19, mtomasz wrote:
> Can we remove this member and just clean the callback after #489?

Added code to clean callback at L489.
We cannot remove cancelRequested_ at least for now, because it is the flag to
see if the current state is "cancelling" or not.
Note that I know that cancelling of FileCopyManager is still broken on some edge
cases. Please let me fix problems one by one, because fixing all problems at a
CL could cause huge diff. I want to focus on fixing copyFileEntry_ in this CL...

https://codereview.chromium.org/22150006/diff/3001/chrome/browser/resources/f...
chrome/browser/resources/file_manager/js/file_copy_manager.js:1023:
errorCallback(util.createFileError(FileError.ABORT_ERR));
On 2013/08/06 01:39:19, mtomasz wrote:
> Can we remove the target file on cancel? It may be completely broken. I don't
> think anyone would want it.

I want to keep this as is, because, IIRC, many OS like linux, win doesn't remove
the intermediate file even the copy operation is cancelled. WDYT?

[mtomasz, 2013-08-06 02:21:38]

https://codereview.chromium.org/22150006/diff/3001/chrome/browser/resources/f...
File chrome/browser/resources/file_manager/js/file_copy_manager.js (right):

https://codereview.chromium.org/22150006/diff/3001/chrome/browser/resources/f...
chrome/browser/resources/file_manager/js/file_copy_manager.js:487:
this.cancelRequested_ = true;
On 2013/08/06 02:14:55, hidehiko wrote:
> On 2013/08/06 01:39:19, mtomasz wrote:
> > Can we remove this member and just clean the callback after #489?
> 
> Added code to clean callback at L489.
> We cannot remove cancelRequested_ at least for now, because it is the flag to
> see if the current state is "cancelling" or not.
> Note that I know that cancelling of FileCopyManager is still broken on some
edge
> cases. Please let me fix problems one by one, because fixing all problems at a
> CL could cause huge diff. I want to focus on fixing copyFileEntry_ in this
CL...

sgtm

https://codereview.chromium.org/22150006/diff/3001/chrome/browser/resources/f...
chrome/browser/resources/file_manager/js/file_copy_manager.js:1023:
errorCallback(util.createFileError(FileError.ABORT_ERR));
On 2013/08/06 02:14:55, hidehiko wrote:
> On 2013/08/06 01:39:19, mtomasz wrote:
> > Can we remove the target file on cancel? It may be completely broken. I
don't
> > think anyone would want it.
> 
> I want to keep this as is, because, IIRC, many OS like linux, win doesn't
remove
> the intermediate file even the copy operation is cancelled. WDYT?

As far as I remember on Windows the file gets removed. Also, when you download a
file and it fails, then the partial file is removed. Please check on Mac if you
have one around.

[mtomasz, 2013-08-06 02:22:28]

https://codereview.chromium.org/22150006/diff/3001/chrome/browser/resources/f...
File chrome/browser/resources/file_manager/js/file_copy_manager.js (right):

https://codereview.chromium.org/22150006/diff/3001/chrome/browser/resources/f...
chrome/browser/resources/file_manager/js/file_copy_manager.js:1023:
errorCallback(util.createFileError(FileError.ABORT_ERR));
On 2013/08/06 02:21:38, mtomasz wrote:
> On 2013/08/06 02:14:55, hidehiko wrote:
> > On 2013/08/06 01:39:19, mtomasz wrote:
> > > Can we remove the target file on cancel? It may be completely broken. I
> don't
> > > think anyone would want it.
> > 
> > I want to keep this as is, because, IIRC, many OS like linux, win doesn't
> remove
> > the intermediate file even the copy operation is cancelled. WDYT?
> 
> As far as I remember on Windows the file gets removed. Also, when you download
a
> file and it fails, then the partial file is removed. Please check on Mac if
you
> have one around.

I meant when downloading a file in Chrome.

[mtomasz, 2013-08-06 03:35:27]

On 2013/08/06 02:22:28, mtomasz wrote:
>
https://codereview.chromium.org/22150006/diff/3001/chrome/browser/resources/f...
> File chrome/browser/resources/file_manager/js/file_copy_manager.js (right):
> 
>
https://codereview.chromium.org/22150006/diff/3001/chrome/browser/resources/f...
> chrome/browser/resources/file_manager/js/file_copy_manager.js:1023:
> errorCallback(util.createFileError(FileError.ABORT_ERR));
> On 2013/08/06 02:21:38, mtomasz wrote:
> > On 2013/08/06 02:14:55, hidehiko wrote:
> > > On 2013/08/06 01:39:19, mtomasz wrote:
> > > > Can we remove the target file on cancel? It may be completely broken. I
> > don't
> > > > think anyone would want it.
> > > 
> > > I want to keep this as is, because, IIRC, many OS like linux, win doesn't
> > remove
> > > the intermediate file even the copy operation is cancelled. WDYT?
> > 
> > As far as I remember on Windows the file gets removed. Also, when you
download
> a
> > file and it fails, then the partial file is removed. Please check on Mac if
> you
> > have one around.
> 
> I meant when downloading a file in Chrome.

According to the discussion offline,
lgtm.

[hidehiko, 2013-08-06 03:48:22]

On 2013/08/06 03:35:27, mtomasz wrote:
> On 2013/08/06 02:22:28, mtomasz wrote:
> >
>
https://codereview.chromium.org/22150006/diff/3001/chrome/browser/resources/f...
> > File chrome/browser/resources/file_manager/js/file_copy_manager.js (right):
> > 
> >
>
https://codereview.chromium.org/22150006/diff/3001/chrome/browser/resources/f...
> > chrome/browser/resources/file_manager/js/file_copy_manager.js:1023:
> > errorCallback(util.createFileError(FileError.ABORT_ERR));
> > On 2013/08/06 02:21:38, mtomasz wrote:
> > > On 2013/08/06 02:14:55, hidehiko wrote:
> > > > On 2013/08/06 01:39:19, mtomasz wrote:
> > > > > Can we remove the target file on cancel? It may be completely broken.
I
> > > don't
> > > > > think anyone would want it.
> > > > 
> > > > I want to keep this as is, because, IIRC, many OS like linux, win
doesn't
> > > remove
> > > > the intermediate file even the copy operation is cancelled. WDYT?
> > > 
> > > As far as I remember on Windows the file gets removed. Also, when you
> download
> > a
> > > file and it fails, then the partial file is removed. Please check on Mac
if
> > you
> > > have one around.
> > 
> > I meant when downloading a file in Chrome.
> 
> According to the discussion offline,
> lgtm.

Thank you! Sending to CQ.
- hidehiko

[commit-bot: I haz the power, 2013-08-06 03:48:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hidehiko@chromium.org/22150006/12001

[commit-bot: I haz the power, 2013-08-06 04:42:36]

Retried try job too often on mac_rel for step(s) remoting_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-08-06 04:43:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hidehiko@chromium.org/22150006/12001

[commit-bot: I haz the power, 2013-08-06 06:20:38]

Change committed as 215820