Issue 22145004: Profile Reset: Don't disable defaults apps

Issue 22145004: Profile Reset: Don't disable defaults apps (Closed)

Created:
7 years, 4 months ago by vasilii

Modified:
7 years, 4 months ago

Reviewers:
asargent_no_longer_on_chrome, battre

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Profile Reset: Don't disable installed by default trusted apps. BUG=267004 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215866

Patch Set 3 : Grammar #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -12 lines)			Patch
M	chrome/browser/extensions/extension_service.h	View	1 2	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_service.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/profile_resetter/profile_resetter_unittest.cc	View		9 chunks	+81 lines, -10 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

vasilii

Hi guys, please review the CL. This is an alternative to https://codereview.chromium.org/21779002/

7 years, 4 months ago (2013-08-05 13:29:08 UTC) #1

battre

LGTM. I think this is the version of the CL we should land. Thanks.

7 years, 4 months ago (2013-08-05 15:20:21 UTC) #2

asargent_no_longer_on_chrome

lgtm https://codereview.chromium.org/22145004/diff/1004/chrome/browser/extensions/extension_service.h File chrome/browser/extensions/extension_service.h (right): https://codereview.chromium.org/22145004/diff/1004/chrome/browser/extensions/extension_service.h#newcode356 chrome/browser/extensions/extension_service.h:356: // |except_ids|. Default extension are those from Web ...

7 years, 4 months ago (2013-08-05 17:31:53 UTC) #3

vasilii

https://codereview.chromium.org/22145004/diff/1004/chrome/browser/extensions/extension_service.h File chrome/browser/extensions/extension_service.h (right): https://codereview.chromium.org/22145004/diff/1004/chrome/browser/extensions/extension_service.h#newcode356 chrome/browser/extensions/extension_service.h:356: // |except_ids|. Default extension are those from Web Store ...

7 years, 4 months ago (2013-08-06 07:43:44 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vasilii@chromium.org/22145004/24001

7 years, 4 months ago (2013-08-06 07:47:00 UTC) #5

Message was sent while issue was closed.

Change committed as 215866

Expand Messages | Collapse Messages