Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Unified Diff: chrome/common/extensions/permissions/permission_set_unittest.cc

Issue 221353003: Make unknown extension subpermissions warnings instead of errors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comments Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/permissions/permission_set_unittest.cc
diff --git a/chrome/common/extensions/permissions/permission_set_unittest.cc b/chrome/common/extensions/permissions/permission_set_unittest.cc
index 77baf5fc52da994842dda3978e28b777dbc8360c..a3b9acf965c2a3f724e15f6f9a93cb3b1f7880a9 100644
--- a/chrome/common/extensions/permissions/permission_set_unittest.cc
+++ b/chrome/common/extensions/permissions/permission_set_unittest.cc
@@ -255,7 +255,7 @@ TEST(PermissionsTest, CreateUnion) {
base::Value::CreateStringValue("tcp-connect:*.example.com:80"));
value->Append(base::Value::CreateStringValue("udp-bind::8080"));
value->Append(base::Value::CreateStringValue("udp-send-to::8888"));
- ASSERT_TRUE(permission->FromValue(value.get(), NULL));
+ ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL));
}
// Union with an empty set.
@@ -300,7 +300,7 @@ TEST(PermissionsTest, CreateUnion) {
value->Append(
base::Value::CreateStringValue("tcp-connect:*.example.com:80"));
value->Append(base::Value::CreateStringValue("udp-send-to::8899"));
- ASSERT_TRUE(permission->FromValue(value.get(), NULL));
+ ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL));
}
apis2.insert(permission);
@@ -317,7 +317,7 @@ TEST(PermissionsTest, CreateUnion) {
value->Append(base::Value::CreateStringValue("udp-bind::8080"));
value->Append(base::Value::CreateStringValue("udp-send-to::8888"));
value->Append(base::Value::CreateStringValue("udp-send-to::8899"));
- ASSERT_TRUE(permission->FromValue(value.get(), NULL));
+ ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL));
}
// Insert a new permission socket permisssion which will replace the old one.
expected_apis.insert(permission);
@@ -384,7 +384,7 @@ TEST(PermissionsTest, CreateIntersection) {
base::Value::CreateStringValue("tcp-connect:*.example.com:80"));
value->Append(base::Value::CreateStringValue("udp-bind::8080"));
value->Append(base::Value::CreateStringValue("udp-send-to::8888"));
- ASSERT_TRUE(permission->FromValue(value.get(), NULL));
+ ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL));
}
apis1.insert(permission);
@@ -421,7 +421,7 @@ TEST(PermissionsTest, CreateIntersection) {
value->Append(base::Value::CreateStringValue("udp-bind::8080"));
value->Append(base::Value::CreateStringValue("udp-send-to::8888"));
value->Append(base::Value::CreateStringValue("udp-send-to::8899"));
- ASSERT_TRUE(permission->FromValue(value.get(), NULL));
+ ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL));
}
apis2.insert(permission);
@@ -431,7 +431,7 @@ TEST(PermissionsTest, CreateIntersection) {
scoped_ptr<base::ListValue> value(new base::ListValue());
value->Append(base::Value::CreateStringValue("udp-bind::8080"));
value->Append(base::Value::CreateStringValue("udp-send-to::8888"));
- ASSERT_TRUE(permission->FromValue(value.get(), NULL));
+ ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL));
}
expected_apis.insert(permission);
@@ -497,7 +497,7 @@ TEST(PermissionsTest, CreateDifference) {
base::Value::CreateStringValue("tcp-connect:*.example.com:80"));
value->Append(base::Value::CreateStringValue("udp-bind::8080"));
value->Append(base::Value::CreateStringValue("udp-send-to::8888"));
- ASSERT_TRUE(permission->FromValue(value.get(), NULL));
+ ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL));
}
apis1.insert(permission);
@@ -522,7 +522,7 @@ TEST(PermissionsTest, CreateDifference) {
value->Append(
base::Value::CreateStringValue("tcp-connect:*.example.com:80"));
value->Append(base::Value::CreateStringValue("udp-send-to::8899"));
- ASSERT_TRUE(permission->FromValue(value.get(), NULL));
+ ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL));
}
apis2.insert(permission);
@@ -532,7 +532,7 @@ TEST(PermissionsTest, CreateDifference) {
scoped_ptr<base::ListValue> value(new base::ListValue());
value->Append(base::Value::CreateStringValue("udp-bind::8080"));
value->Append(base::Value::CreateStringValue("udp-send-to::8888"));
- ASSERT_TRUE(permission->FromValue(value.get(), NULL));
+ ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL));
}
expected_apis.insert(permission);

Powered by Google App Engine
This is Rietveld 408576698