Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: extensions/common/permissions/settings_override_permission.cc

Issue 221353003: Make unknown extension subpermissions warnings instead of errors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/permissions/settings_override_permission.cc
diff --git a/extensions/common/permissions/settings_override_permission.cc b/extensions/common/permissions/settings_override_permission.cc
index b58d937d786ddbe5316387945a1b2545e1d597d3..63d8848fc4f126f76447ec3e9b5be8a6ee3ef753 100644
--- a/extensions/common/permissions/settings_override_permission.cc
+++ b/extensions/common/permissions/settings_override_permission.cc
@@ -64,8 +64,10 @@ bool SettingsOverrideAPIPermission::Equal(const APIPermission* rhs) const {
return true;
}
-bool SettingsOverrideAPIPermission::FromValue(const base::Value* value,
- std::string* /*error*/) {
+bool SettingsOverrideAPIPermission::FromValue(
+ const base::Value* value,
+ std::string* /*error*/,
+ std::vector<std::string>* unhandled_permissions) {
return (value == NULL);
}

Powered by Google App Engine
This is Rietveld 408576698