Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7388)

Unified Diff: chrome/common/extensions/permissions/socket_permission_unittest.cc

Issue 221353003: Make unknown extension subpermissions warnings instead of errors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/permissions/socket_permission_unittest.cc
diff --git a/chrome/common/extensions/permissions/socket_permission_unittest.cc b/chrome/common/extensions/permissions/socket_permission_unittest.cc
index 7cb1b9f58685a18326563537b33e5032e426b8e2..bcbeb97900c4f11842ea7f7a32451b7a955a6be9 100644
--- a/chrome/common/extensions/permissions/socket_permission_unittest.cc
+++ b/chrome/common/extensions/permissions/socket_permission_unittest.cc
@@ -293,7 +293,7 @@ TEST(SocketPermissionTest, IPC) {
value->AppendString("tcp-connect:*.example.com:80");
value->AppendString("udp-bind::8080");
value->AppendString("udp-send-to::8888");
- ASSERT_TRUE(permission1->FromValue(value.get(), NULL));
+ ASSERT_TRUE(permission1->FromValue(value.get(), NULL, NULL));
EXPECT_FALSE(permission1->Equal(permission2.get()));
@@ -317,13 +317,13 @@ TEST(SocketPermissionTest, Value) {
value->AppendString("tcp-connect:*.example.com:80");
value->AppendString("udp-bind::8080");
value->AppendString("udp-send-to::8888");
- ASSERT_TRUE(permission1->FromValue(value.get(), NULL));
+ ASSERT_TRUE(permission1->FromValue(value.get(), NULL, NULL));
EXPECT_FALSE(permission1->Equal(permission2.get()));
scoped_ptr<base::Value> vtmp(permission1->ToValue());
ASSERT_TRUE(vtmp);
- ASSERT_TRUE(permission2->FromValue(vtmp.get(), NULL));
+ ASSERT_TRUE(permission2->FromValue(vtmp.get(), NULL, NULL));
EXPECT_TRUE(permission1->Equal(permission2.get()));
}

Powered by Google App Engine
This is Rietveld 408576698