Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Side by Side Diff: extensions/common/permissions/settings_override_permission.cc

Issue 221353003: Make unknown extension subpermissions warnings instead of errors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comments Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « extensions/common/permissions/settings_override_permission.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/common/permissions/settings_override_permission.h" 5 #include "extensions/common/permissions/settings_override_permission.h"
6 6
7 #include "base/strings/utf_string_conversions.h" 7 #include "base/strings/utf_string_conversions.h"
8 #include "grit/generated_resources.h" 8 #include "grit/generated_resources.h"
9 #include "ui/base/l10n/l10n_util.h" 9 #include "ui/base/l10n/l10n_util.h"
10 10
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 CHECK_EQ(info(), rhs->info()); 57 CHECK_EQ(info(), rhs->info());
58 return true; 58 return true;
59 } 59 }
60 60
61 bool SettingsOverrideAPIPermission::Equal(const APIPermission* rhs) const { 61 bool SettingsOverrideAPIPermission::Equal(const APIPermission* rhs) const {
62 if (this != rhs) 62 if (this != rhs)
63 CHECK_EQ(info(), rhs->info()); 63 CHECK_EQ(info(), rhs->info());
64 return true; 64 return true;
65 } 65 }
66 66
67 bool SettingsOverrideAPIPermission::FromValue(const base::Value* value, 67 bool SettingsOverrideAPIPermission::FromValue(
68 std::string* /*error*/) { 68 const base::Value* value,
69 std::string* /*error*/,
70 std::vector<std::string>* unhandled_permissions) {
69 return (value == NULL); 71 return (value == NULL);
70 } 72 }
71 73
72 scoped_ptr<base::Value> SettingsOverrideAPIPermission::ToValue() const { 74 scoped_ptr<base::Value> SettingsOverrideAPIPermission::ToValue() const {
73 return scoped_ptr<base::Value>(); 75 return scoped_ptr<base::Value>();
74 } 76 }
75 77
76 APIPermission* SettingsOverrideAPIPermission::Clone() const { 78 APIPermission* SettingsOverrideAPIPermission::Clone() const {
77 return new SettingsOverrideAPIPermission(info(), setting_value_); 79 return new SettingsOverrideAPIPermission(info(), setting_value_);
78 } 80 }
(...skipping 19 matching lines...) Expand all
98 void SettingsOverrideAPIPermission::Write(IPC::Message* m) const {} 100 void SettingsOverrideAPIPermission::Write(IPC::Message* m) const {}
99 101
100 bool SettingsOverrideAPIPermission::Read(const IPC::Message* m, 102 bool SettingsOverrideAPIPermission::Read(const IPC::Message* m,
101 PickleIterator* iter) { 103 PickleIterator* iter) {
102 return true; 104 return true;
103 } 105 }
104 106
105 void SettingsOverrideAPIPermission::Log(std::string* log) const {} 107 void SettingsOverrideAPIPermission::Log(std::string* log) const {}
106 108
107 } // namespace extensions 109 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/common/permissions/settings_override_permission.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698