Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: extensions/common/permissions/settings_override_permission.h

Issue 221353003: Make unknown extension subpermissions warnings instead of errors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_COMMON_PERMISSIONS_SETTINGS_OVERRIDE_PERMISSION_H_ 5 #ifndef EXTENSIONS_COMMON_PERMISSIONS_SETTINGS_OVERRIDE_PERMISSION_H_
6 #define EXTENSIONS_COMMON_PERMISSIONS_SETTINGS_OVERRIDE_PERMISSION_H_ 6 #define EXTENSIONS_COMMON_PERMISSIONS_SETTINGS_OVERRIDE_PERMISSION_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "extensions/common/permissions/api_permission.h" 10 #include "extensions/common/permissions/api_permission.h"
11 11
12 namespace extensions { 12 namespace extensions {
13 13
14 // Takes care of creating custom permission messages for extensions that 14 // Takes care of creating custom permission messages for extensions that
15 // override settings. 15 // override settings.
16 class SettingsOverrideAPIPermission : public APIPermission { 16 class SettingsOverrideAPIPermission : public APIPermission {
17 public: 17 public:
18 SettingsOverrideAPIPermission(const APIPermissionInfo* permission, 18 SettingsOverrideAPIPermission(const APIPermissionInfo* permission,
19 const std::string& setting_value); 19 const std::string& setting_value);
20 virtual ~SettingsOverrideAPIPermission(); 20 virtual ~SettingsOverrideAPIPermission();
21 21
22 // APIPermission overrides. 22 // APIPermission overrides.
23 virtual bool HasMessages() const OVERRIDE; 23 virtual bool HasMessages() const OVERRIDE;
24 virtual PermissionMessages GetMessages() const OVERRIDE; 24 virtual PermissionMessages GetMessages() const OVERRIDE;
25 virtual bool Check(const APIPermission::CheckParam* param) const OVERRIDE; 25 virtual bool Check(const APIPermission::CheckParam* param) const OVERRIDE;
26 virtual bool Contains(const APIPermission* rhs) const OVERRIDE; 26 virtual bool Contains(const APIPermission* rhs) const OVERRIDE;
27 virtual bool Equal(const APIPermission* rhs) const OVERRIDE; 27 virtual bool Equal(const APIPermission* rhs) const OVERRIDE;
28 virtual bool FromValue(const base::Value* value, std::string* error) OVERRIDE; 28 virtual bool FromValue(
29 const base::Value* value,
30 std::string* error,
31 std::vector<std::string>* unhandled_permissions) OVERRIDE;
29 virtual scoped_ptr<base::Value> ToValue() const OVERRIDE; 32 virtual scoped_ptr<base::Value> ToValue() const OVERRIDE;
30 virtual APIPermission* Clone() const OVERRIDE; 33 virtual APIPermission* Clone() const OVERRIDE;
31 virtual APIPermission* Diff(const APIPermission* rhs) const OVERRIDE; 34 virtual APIPermission* Diff(const APIPermission* rhs) const OVERRIDE;
32 virtual APIPermission* Union(const APIPermission* rhs) const OVERRIDE; 35 virtual APIPermission* Union(const APIPermission* rhs) const OVERRIDE;
33 virtual APIPermission* Intersect(const APIPermission* rhs) const OVERRIDE; 36 virtual APIPermission* Intersect(const APIPermission* rhs) const OVERRIDE;
34 virtual void Write(IPC::Message* m) const OVERRIDE; 37 virtual void Write(IPC::Message* m) const OVERRIDE;
35 virtual bool Read(const IPC::Message* m, PickleIterator* iter) OVERRIDE; 38 virtual bool Read(const IPC::Message* m, PickleIterator* iter) OVERRIDE;
36 virtual void Log(std::string* log) const OVERRIDE; 39 virtual void Log(std::string* log) const OVERRIDE;
37 40
38 private: 41 private:
39 std::string setting_value_; 42 std::string setting_value_;
40 }; 43 };
41 44
42 } // namespace extensions 45 } // namespace extensions
43 46
44 #endif // EXTENSIONS_COMMON_PERMISSIONS_SETTINGS_OVERRIDE_PERMISSION_H_ 47 #endif // EXTENSIONS_COMMON_PERMISSIONS_SETTINGS_OVERRIDE_PERMISSION_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698